X-Git-Url: https://ruderich.org/simon/gitweb/?a=blobdiff_plain;f=bin%2Fblhc;h=d53c7d7b849a01b62610263e851dde695f26dd41;hb=992cc016c9d07fab61701a75a0957dcfda83c77d;hp=813936890b9369de332a6a9648bff06c6e9a05ba;hpb=de65359d7659f6fbadeb128abf39ff881e05c458;p=blhc%2Fblhc.git

diff --git a/bin/blhc b/bin/blhc
index 8139368..d53c7d7 100755
--- a/bin/blhc
+++ b/bin/blhc
@@ -27,6 +27,50 @@ use Term::ANSIColor ();
 our $VERSION = '0.01';
 
 
+# CONSTANTS/VARIABLES
+
+# Regex to catch compiler commands.
+my $cc_regex = qr/(?:x86_64-linux-gnu-)?(?:(?<!\.)cc|gcc|g\+\+|c\+\+)(?:-[\d.]+)?/;
+# Regex to catch (GCC) compiler warnings.
+my $warning_regex = qr/^(.+?):([0-9]+):[0-9]+: warning: (.+?) \[(.+?)\]$/;
+
+# Expected hardening flags. All flags are used as regexps.
+my @cflags = (
+    '-g',
+    '-O2',
+    '-fstack-protector',
+    '--param=ssp-buffer-size=4',
+    '-Wformat',
+    '-Wformat-security',
+    '-Werror=format-security',
+);
+my @cflags_pie = (
+    '-fPIE',
+);
+my @cppflags = (
+    '-D_FORTIFY_SOURCE=2',
+);
+my @ldflags = (
+    '-Wl,(-z,)?relro',
+);
+my @ldflags_pie = (
+    '-fPIE',
+    '-pie',
+);
+my @ldflags_bindnow = (
+    '-Wl,(-z,)?now',
+);
+# All (hardening) flags.
+my @flags = (@cflags, @cflags_pie,
+             @cppflags,
+             @ldflags, @ldflags_pie, @ldflags_bindnow);
+# Renaming rules for the output so the regex parts are not visible.
+my %flag_renames = (
+    '-Wl,(-z,)?relro' => '-Wl,-z,relro',
+    '-Wl,(-z,)?now'   => '-Wl,-z,now',
+);
+
+
 # FUNCTIONS
 
 sub error_flags {
@@ -67,7 +111,7 @@ sub any_flags_used {
     my ($line, @flags) = @_;
 
     foreach my $flag (@flags) {
-        return 1 if $line =~ /\s$flag(\s|\\|$)/;
+        return 1 if $line =~ /\s$flag(?:\s|\\|$)/;
     }
 
     return 0;
@@ -77,7 +121,7 @@ sub all_flags_used {
 
     my @missing_flags = ();
     foreach my $flag (@flags) {
-        if ($line !~ /\s$flag(\s|\\|$)/) {
+        if ($line !~ /\s$flag(?:\s|\\|$)/) {
             push @missing_flags, $flag;
         }
     }
@@ -113,30 +157,32 @@ sub pic_pie_conflict {
 }
 
 sub is_non_verbose_build {
-    my ($line, $next_line, $cc_regex, $skip_ref) = @_;
+    my ($line, $next_line, $skip_ref) = @_;
 
-    my $cmake_non_verbose = qr/^\s*\[[\d ]+%\] Building (C|CXX) object (.+?)$/;
     if (not ($line =~ /^checking if you want to see long compiling messages\.\.\. no/
-                or $line =~ /^\s*(CC|CCLD)\s+/
-                or $line =~ /^\s*(C|c)ompiling\s+/
-                or $line =~ /$cmake_non_verbose/)) {
+                or $line =~ /^\s*(?:CC|CCLD)\s+(.+?)$/
+                or $line =~ /^\s*(?:C|c)ompiling\s+(.+?)(?:\.\.\.)?$/
+                or $line =~ /^\s*(?:B|b)uilding (?:program|shared library)\s+(.+?)$/
+                or $line =~ /^\s*\[[\d ]+%\] Building (?:C|CXX) object (.+?)$/)) {
         return 0;
     }
 
+    my $file = $1;
+
     # On the first pass we only check if this line is verbose or not.
     return 1 if not defined $next_line;
 
     # Second pass, we have access to the next line.
     ${$skip_ref} = 0;
 
-    # CMake prints the non-verbose messages also when building verbose. If a
-    # compiler and the file name occurs in the next line, treat it as verbose
-    # build.
-    if ($line =~ /$cmake_non_verbose/) {
+    # CMake and other build systems print the non-verbose messages also when
+    # building verbose. If a compiler and the file name occurs in the next
+    # line, treat it as verbose build.
+    if (defined $file) {
         # Get filename, we can't use the complete path as only parts of it are
-        # used in the real compiler command ...
-        $2 =~ m{/([a-zA-Z0-9._-]+)$};
-        my $file = $1;
+        # used in the real compiler command.
+        $file =~ m{/([a-zA-Z0-9._-]+)$};
+        $file = $1;
 
         if ($next_line =~ /\Q$file\E/ and $next_line =~ /$cc_regex/) {
             # We still have to skip the current line as it doesn't contain any
@@ -150,50 +196,6 @@ sub is_non_verbose_build {
 }
 
 
-# CONSTANTS/VARIABLES
-
-# Regex to catch compiler commands.
-my $cc_regex = qr/((?<!\.)cc|(x86_64-linux-gnu-)?gcc|g\+\+|c\+\+)/;
-# Regex to catch (GCC) compiler warnings.
-my $warning_regex = qr/^(.+?):([0-9]+):[0-9]+: warning: (.+?) \[(.+?)\]$/;
-
-# Expected hardening flags. All flags are used as regexps.
-my @cflags = (
-    '-g',
-    '-O2',
-    '-fstack-protector',
-    '--param=ssp-buffer-size=4',
-    '-Wformat',
-    '-Wformat-security',
-    '-Werror=format-security',
-);
-my @cflags_pie = (
-    '-fPIE',
-);
-my @cppflags = (
-    '-D_FORTIFY_SOURCE=2',
-);
-my @ldflags = (
-    '-Wl,(-z,)?relro',
-);
-my @ldflags_pie = (
-    '-fPIE',
-    '-pie',
-);
-my @ldflags_bindnow = (
-    '-Wl,(-z,)?now',
-);
-# All (hardening) flags.
-my @flags = (@cflags, @cflags_pie,
-             @cppflags,
-             @ldflags, @ldflags_pie, @ldflags_bindnow);
-# Renaming rules for the output so the regex parts are not visible.
-my %flag_renames = (
-    '-Wl,(-z,)?relro' => '-Wl,-z,relro',
-    '-Wl,(-z,)?now'   => '-Wl,-z,now',
-);
-
-
 # MAIN
 
 # Additional hardening options.
@@ -248,8 +250,14 @@ my $exit = 0;
 # Input lines, contain only the lines with compiler commands.
 my @input = ();
 
+my $start = 0;
 my $continuation = 0;
 while (my $line = <>) {
+    # We skip over unimportant lines at the beginning to prevent false
+    # positives.
+    $start = 1 if $line =~ /^dpkg-buildpackage:/;
+    next if not $start;
+
     # Ignore compiler warnings for now.
     next if $line =~ /$warning_regex/;
 
@@ -274,7 +282,7 @@ while (my $line = <>) {
 
         } else {
             # Ignore lines with no compiler commands.
-            next if $line !~ /\b$cc_regex(\s|\\)/ and not $non_verbose;
+            next if $line !~ /\b$cc_regex(?:\s|\\)/ and not $non_verbose;
 
             # Ignore false positives.
             #
@@ -316,7 +324,7 @@ for (my $i = 0; $i < scalar @input; $i++) {
     my $line = $input[$i];
 
     my $skip = 0;
-    if (is_non_verbose_build($line, $input[$i + 1], $cc_regex, \$skip)) {
+    if (is_non_verbose_build($line, $input[$i + 1], \$skip)) {
         error_non_verbose_build($line);
         $exit |= 1 << 2;
         next;
@@ -327,22 +335,22 @@ for (my $i = 0; $i < scalar @input; $i++) {
     # Ignore false positives.
     #
     # ./configure summary.
-    next if $line =~ /^\s*(C|c)ompiler[\s.]*:\s+$cc_regex(\s-std=[a-z0-9:+]+)?\s*$/
-            or $line =~ /^\s*- (CC|CXX)\s*=\s*$cc_regex\s*$/
-            or $line =~ /^\s*-- Check for working (C|CXX) compiler: /;
+    next if $line =~ /^\s*(?:C|c)ompiler[\s.]*:\s+$cc_regex(?:\s-std=[a-z0-9:+]+)?\s*$/
+            or $line =~ /^\s*- (?:CC|CXX)\s*=\s*$cc_regex\s*$/
+            or $line =~ /^\s*-- Check for working (?:C|CXX) compiler: /;
 
     # Is this a compiler or linker command?
     my $compiler = 1;
     my $linker   = 0;
 
     # Linker commands.
-    if ($line =~ m{\s-o                      # -o
-                   [\s\\]*\s+                # possible line continuation
-                   ([A-Za-z0-9_/.-]+/)?      # path to file
-                   [A-Za-z0-9_-]+            # binary name (no dots!)
-                   ([0-9.]*\.so[0-9.]*[a-z]? # library (including version)
+    if ($line =~ m{\s-o                        # -o
+                   [\s\\]*\s+                  # possible line continuation
+                   (?:[/.A-Za-z0-9~_-]+/)?     # path to file
+                        [A-Za-z0-9~_-]+        # binary name (no dots!)
+                   (?:[0-9.]*\.so[0-9.]*[a-z]? # library (including version)
                     |\.la)?
-                   (\s|\\|\$)                # end of file name
+                   (?:\s|\\|$)                 # end of file name
                   }x
             or $line =~ /^libtool: link: /
             or $line =~ m{\s*/bin/bash .+?libtool\s+(.+?\s+)?--mode=(re)?link}) {
@@ -352,7 +360,7 @@ for (my $i = 0; $i < scalar @input; $i++) {
 
     # If there are source files then it's compiling/linking in one step and we
     # must check both.
-    if ($line =~ /\.(c|cc|cpp)\b/) {
+    if ($line =~ /\.(?:c|cc|cpp)\b/) {
         $compiler = 1;
     }