X-Git-Url: https://ruderich.org/simon/gitweb/?a=blobdiff_plain;f=cmd%2Fsafcm%2Fconfig%2Fgroups.go;h=571f19b7fcb10b5adcd4c5e406d6f22e5b585730;hb=e452996e2008d438aa68dedbd206525f507b73d3;hp=386a9a773468d47f9dd4d9779c5df25856e57493;hpb=bd6ba5af0268551d7ca59ba4bb52a72f30af3b53;p=safcm%2Fsafcm.git diff --git a/cmd/safcm/config/groups.go b/cmd/safcm/config/groups.go index 386a9a7..571f19b 100644 --- a/cmd/safcm/config/groups.go +++ b/cmd/safcm/config/groups.go @@ -34,7 +34,7 @@ const ( GroupRemoveSuffix = GroupSpecialSeparator + "remove" ) -// Keep in sync with sync_info.go:infoGroupDetectedRegexp +// Keep in sync with cmd/safcm/sync_info.go:infoGroupDetectedRegexp var groupNameRegexp = regexp.MustCompile(`^[a-z0-9_-]+$`) func LoadGroups(cfg *Config, hosts *Hosts) (map[string][]string, error) { @@ -86,6 +86,8 @@ func LoadGroups(cfg *Config, hosts *Hosts) (map[string][]string, error) { if x == GroupAll { continue } + // Don't validate against groupNameRegexp because + // hosts have less strict restrictions. if strings.Contains(x, GroupSpecialSeparator) { return nil, fmt.Errorf( "%s member %q must not contain %q", @@ -97,14 +99,14 @@ func LoadGroups(cfg *Config, hosts *Hosts) (map[string][]string, error) { if hosts.Map[x] != nil || groups[x] != nil { continue } - return nil, fmt.Errorf("%s group %q not found", + return nil, fmt.Errorf("%s member %q not found", errPrefix, x) } } // Sanity check for global configuration - for _, x := range cfg.GroupOrder { - const errPrefix = "config.yaml: group_order:" + for _, x := range cfg.GroupPriority { + const errPrefix = "config.yaml: group_priority:" if x == GroupAll { continue @@ -126,8 +128,7 @@ func LoadGroups(cfg *Config, hosts *Hosts) (map[string][]string, error) { return groups, nil } -func ResolveHostGroups(host string, - groups map[string][]string, +func ResolveHostGroups(host string, groups map[string][]string, detectedGroups []string) ([]string, error) { const maxDepth = 100