X-Git-Url: https://ruderich.org/simon/gitweb/?a=blobdiff_plain;f=cmd%2Fsafcm%2Fsync.go;h=7fa2c936b637c7059e5429b273f310233ee92ed4;hb=4473e968425319e6beae558643bb047a6b01c17a;hp=e8f643154851a5fd91cd6b5647c9da84d73ddb4a;hpb=cc1ca940efef242decfa8bd4adc2e0d9cbf6a210;p=safcm%2Fsafcm.git

diff --git a/cmd/safcm/sync.go b/cmd/safcm/sync.go
index e8f6431..7fa2c93 100644
--- a/cmd/safcm/sync.go
+++ b/cmd/safcm/sync.go
@@ -186,8 +186,24 @@ func MainSync(args []string) error {
 func hostsToSync(names []string, allHosts *config.Hosts,
 	allGroups map[string][]string) ([]*config.Host, error) {
 
+	detectedMap := make(map[string]bool)
+	for _, x := range config.TransitivelyDetectedGroups(allGroups) {
+		detectedMap[x] = true
+	}
+
+	const detectedErr = `
+
+Groups depending on "detected" groups cannot be used to select hosts as these
+are only available after the hosts were contacted.
+`
+
 	nameMap := make(map[string]bool)
 	for _, x := range names {
+		if detectedMap[x] {
+			return nil, fmt.Errorf(
+				"group %q depends on \"detected\" groups%s",
+				x, detectedErr)
+		}
 		nameMap[x] = true
 	}
 	nameMatched := make(map[string]bool)
@@ -203,8 +219,6 @@ func hostsToSync(names []string, allHosts *config.Hosts,
 			nameMatched[host.Name] = true
 		}
 
-		// TODO: don't permit groups which contain "detected" groups
-		// because these are not available yet
 		groups, err := config.ResolveHostGroups(host.Name,
 			allGroups, nil)
 		if err != nil {