X-Git-Url: https://ruderich.org/simon/gitweb/?a=blobdiff_plain;f=cmd%2Fsafcm%2Fsync_sync.go;h=0d5a722d9ef59b0461550532adcef372725db767;hb=0d6364c68d5e523f3c69b93d48cadfb7c150b652;hp=930a263998566c3a71563b30c1e374f6ada06ecb;hpb=45f6c93c3d7ef4a300707bb96d4a1e1fce6df55f;p=safcm%2Fsafcm.git

diff --git a/cmd/safcm/sync_sync.go b/cmd/safcm/sync_sync.go
index 930a263..0d5a722 100644
--- a/cmd/safcm/sync_sync.go
+++ b/cmd/safcm/sync_sync.go
@@ -47,7 +47,7 @@ func (s *Sync) hostSync(conn *rpc.Conn, detectedGroups []string) error {
 	// Display changes
 	changes := s.formatChanges(resp)
 	if changes != "" {
-		s.logf(safcm.LogInfo, true, "%s", changes)
+		s.log(safcm.LogInfo, true, changes)
 	}
 
 	if resp.Error != "" {
@@ -83,9 +83,9 @@ func (s *Sync) hostSyncReq(detectedGroups []string) (
 		sort.Slice(priorities, func(i, j int) bool {
 			a := priorities[i]
 			b := priorities[j]
-			return groupPriority[a] < groupPriority[b]
+			return groupPriority[a] > groupPriority[b]
 		})
-		s.logVerbosef("host group priorities (desc. priority): %v",
+		s.logVerbosef("host group priorities (descending): %v",
 			strings.Join(priorities, " "))
 	}
 
@@ -186,21 +186,21 @@ func (s *Sync) resolveHostGroups(detectedGroups []string) (
 		return nil, nil, err
 	}
 
-	// Early entries have higher priorities
+	// Early entries in "group_priority" have higher priorities
 	groupPriority := make(map[string]int)
 	for i, x := range s.config.GroupPriority {
-		groupPriority[x] = math.MinInt32 + i + 1
+		groupPriority[x] = len(s.config.GroupPriority) - i
 	}
 	// Host itself always has highest priority
-	groupPriority[s.host.Name] = math.MinInt32
+	groupPriority[s.host.Name] = math.MaxInt32
 
 	// Sort groups after priority and name
 	sort.Slice(groups, func(i, j int) bool {
 		a := groups[i]
 		b := groups[j]
-		if groupPriority[a] > groupPriority[b] {
+		if groupPriority[a] < groupPriority[b] {
 			return true
-		} else if groupPriority[a] < groupPriority[b] {
+		} else if groupPriority[a] > groupPriority[b] {
 			return false
 		} else {
 			return a < b
@@ -220,7 +220,7 @@ func (s *Sync) checkFileConflict(group string, path string, file *safcm.File,
 
 	newPrio := groupPriority[group]
 	oldPrio := groupPriority[old.OrigGroup]
-	if oldPrio > newPrio {
+	if oldPrio < newPrio {
 		if old.Mode.IsDir() && file.Mode.IsDir() &&
 			old.TriggerCommands != nil {
 			s.logDebugf("files: %q: "+
@@ -228,7 +228,7 @@ func (s *Sync) checkFileConflict(group string, path string, file *safcm.File,
 				path, group, old.OrigGroup)
 		}
 		return nil
-	} else if oldPrio < newPrio {
+	} else if oldPrio > newPrio {
 		// Should never happen, groups are sorted by priority
 		panic("invalid group priorities")
 	}
@@ -241,7 +241,7 @@ func (s *Sync) checkFileConflict(group string, path string, file *safcm.File,
 		return nil
 	}
 
-	return fmt.Errorf("groups %s and %s both provide file %q\n"+
+	return fmt.Errorf("groups %s and %s both provide %q\n"+
 		"Use 'group_priority' in config.yaml to declare preference",
 		group, old.OrigGroup, path)
 }