X-Git-Url: https://ruderich.org/simon/gitweb/?a=blobdiff_plain;f=src%2Fconnection.c;h=4538f7532fd5681bf49c775c80ee36dd00f817c5;hb=1af69c9609af41165498e7a1bfda3f32744f12fe;hp=07885dfdeed9337468593376c381c9a57411580f;hpb=20c6108edbd40e08b841683d56dbad049ed11d88;p=tlsproxy%2Ftlsproxy.git diff --git a/src/connection.c b/src/connection.c index 07885df..4538f75 100644 --- a/src/connection.c +++ b/src/connection.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include @@ -617,6 +618,7 @@ static void tls_send_invalid_cert_message(gnutls_session_t session) { const char msg[] = "Server certificate validation failed, check logs."; int result; + ssize_t size_written; char buffer[sizeof(HTTP_RESPONSE_FORMAT) + 3 * sizeof(error) + sizeof(msg)]; @@ -624,7 +626,13 @@ static void tls_send_invalid_cert_message(gnutls_session_t session) { error, "", error, error, msg); assert(result > 0 && (size_t)result < sizeof(buffer)); - gnutls_record_send(session, buffer, strlen(buffer)); + size_written = gnutls_record_send(session, buffer, strlen(buffer)); + if (size_written < 0) { + LOG(WARNING, "tls_send_invalid_cert_message(): " + "gnutls_record_send(): %s", + gnutls_strerror((int)size_written)); + } + /* Just an error message, no need to check if everything was written. */ } @@ -778,6 +786,22 @@ static int read_from_write_to_tls(gnutls_session_t from, size_read = gnutls_record_recv(from, buffer, buffer_size); if (size_read < 0) { + /* Allow rehandshakes. As handshakes might be insecure make sure that + * %SAFE_RENEGOTIATION is used in GnuTLS's priority string. */ + if (size_read == GNUTLS_E_REHANDSHAKE) { + int result; + + LOG(DEBUG1, "server requested TLS rehandshake"); + + result = gnutls_handshake(from); + if (result != GNUTLS_E_SUCCESS) { + LOG(WARNING, "server TLS rehandshake failed: %s", + gnutls_strerror(result)); + return -1; + } + return 0; + } + LOG(WARNING, "read_from_write_to_tls(): gnutls_record_recv(): %s", gnutls_strerror((int)size_read)); return -1; @@ -820,8 +844,10 @@ static int connect_to_host(const char *hostname, const char *port) { gai_hints.ai_socktype = SOCK_STREAM; gai_hints.ai_protocol = 0; gai_hints.ai_flags = AI_NUMERICSERV /* given port is numeric */ +#ifdef AI_ADDRCONFIG | AI_ADDRCONFIG /* supported by this computer */ - | AI_V4MAPPED; /* support IPv4 through IPv6 */ +#endif + ; gai_return = getaddrinfo(hostname, port, &gai_hints, &gai_result); if (gai_return != 0) { if (gai_return == EAI_SYSTEM) {