X-Git-Url: https://ruderich.org/simon/gitweb/?a=blobdiff_plain;f=src%2Fverify.c;h=6558d42866422a9a85b8f6ce4ae0fb526a20bc35;hb=80e82203daef6daf7a16219876fc404e12f82c8a;hp=0052ca61cdb73bb5d2994bbe30df22a697b982c8;hpb=5f6ff9f4d1bb1f4bdc01700110435aa1b29c2bcf;p=tlsproxy%2Ftlsproxy.git diff --git a/src/verify.c b/src/verify.c index 0052ca6..6558d42 100644 --- a/src/verify.c +++ b/src/verify.c @@ -109,28 +109,8 @@ int verify_tls_connection(gnutls_session_t session, const char *hostname) { /* We got the certificate as PEM, free it. */ gnutls_x509_crt_deinit(cert); - /* Hostname too long. */ - if (sizeof(path) - strlen(STORED_SERVER_CERT_FORMAT) <= strlen(hostname)) { - LOG(LOG_WARNING, - "verify_tls_connection(): hostname too long: '%s'", - hostname); - return -1; - } - /* Try to prevent path traversals in hostnames. */ - if (NULL != strstr(hostname, "..")) { - LOG(LOG_WARNING, - "verify_tls_connection(): possible path traversal: '%s'", - hostname); - return -1; - } - snprintf(path, sizeof(path), STORED_SERVER_CERT_FORMAT, hostname); - - /* Open the stored certificate file. */ - file = fopen(path, "rb"); - if (NULL == file) { - LOG(LOG_WARNING, - "verify_tls_connection(): failed to open '%s': %s", - path, strerror(errno)); + /* Open stored server certificate file. */ + if (0 != server_certificate_path(&file, hostname, path, sizeof(path))) { return -1; } @@ -168,3 +148,33 @@ int verify_tls_connection(gnutls_session_t session, const char *hostname) { return 0; } + +int server_certificate_path(FILE **file, const char *hostname, char *path, size_t size) { + /* Hostname too long. */ + if (size - strlen(STORED_SERVER_CERT_FORMAT) <= strlen(hostname)) { + LOG(LOG_WARNING, + "server_certificate_path(): hostname too long: '%s'", + hostname); + return -1; + } + /* Try to prevent path traversals in hostnames. */ + if (NULL != strstr(hostname, "..")) { + LOG(LOG_WARNING, + "server_certificate_path(): possible path traversal: '%s'", + hostname); + return -1; + } + snprintf(path, size, STORED_SERVER_CERT_FORMAT, hostname); + + /* Open the stored certificate file. */ + *file = fopen(path, "rb"); + if (NULL == *file) { + LOG(global_passthrough_unknown ? LOG_DEBUG : LOG_WARNING, + "server_certificate_path(): failed to open '%s': %s", + path, strerror(errno)); + /* Couldn't open the file, special case. */ + return -2; + } + + return 0; +}