From: Simon Ruderich <simon@ruderich.org>
Date: Sat, 1 Nov 2025 09:32:58 +0000 (+0100)
Subject: remote: tests: remove call to math/rand.Seed which is a no-op
X-Git-Url: https://ruderich.org/simon/gitweb/?a=commitdiff_plain;h=0bcd287fcf625bb7c7ba51bb7f29c0436a02e3e2;p=safcm%2Fsafcm.git

remote: tests: remove call to math/rand.Seed which is a no-op

I misjudged the linter warning in 5141405 (Update dependencies, static
checkers and Go to 1.24, 2025-10-17). rand.Seed is a no-op since 1.24.

The test works fine without a static seed.
---

diff --git a/remote/sync/files_test.go b/remote/sync/files_test.go
index 2472a15..4f46935 100644
--- a/remote/sync/files_test.go
+++ b/remote/sync/files_test.go
@@ -6,7 +6,6 @@ package sync
 import (
 	"fmt"
 	"io/fs"
-	"math/rand"
 	"os"
 	"regexp"
 	"testing"
@@ -3006,9 +3005,6 @@ file
 				t.Fatal(err)
 			}
 
-			// Deterministic temporary symlink names
-			rand.Seed(0) //nolint:staticcheck // SA1019 need fixed seed
-
 			var changed bool
 			err = s.syncFile(tc.file, &changed)
 			testutil.AssertErrorEqual(t, "err", err, tc.expErr)