From: Simon Ruderich <simon@ruderich.org>
Date: Sat, 11 Feb 2017 01:32:31 +0000 (+0100)
Subject: Improve comments
X-Git-Tag: 0.1~12
X-Git-Url: https://ruderich.org/simon/gitweb/?a=commitdiff_plain;h=7b101456491c5fcaa5b7f275bef98fe8fe012273;p=ptyas%2Fptyas.git

Improve comments
---

diff --git a/ptyas.c b/ptyas.c
index a67f876..c21c6ae 100644
--- a/ptyas.c
+++ b/ptyas.c
@@ -223,7 +223,7 @@ static void proxy_input_between_ttys(int pty_master, int ctty, volatile pid_t *p
         }
 
         /* Handle errors first. (Data available before the error occurred
-         * might be skipped, but shouldn't matter here.) */
+         * might be dropped, but shouldn't matter here.) */
         if (fds[0].revents & (POLLERR | POLLNVAL)) {
             fprintf(stderr, "poll: error on master: %d\n", fds[0].revents);
             break;
@@ -359,6 +359,9 @@ int main(int argc, char **argv) {
         if (pid == -1) {
             die("fork child");
         } else if (pid == 0) {
+            /* Drop the privileges just now so that the other user doesn't get
+             * access to the master TTY or the session leader (which might
+             * have additional privileges). */
             drop_privileges_or_die(uid, gid);
 
             dup2_or_die(pty_slave, STDIN_FILENO);
@@ -441,7 +444,7 @@ int main(int argc, char **argv) {
         die("tcsetattr restore");
     }
 
-    /* Wait until we got the status code from our child. poll() might also
+    /* Wait until we got the status code from our child. poll() might already
      * exit after POLLHUP while we haven't collected the child yet. */
     if (sigprocmask(SIG_BLOCK, &sigset, &sigset_old) != 0) {
         die("sigprocmask block sigchld loop");