From: Simon Ruderich Date: Sun, 8 Jul 2012 12:53:02 +0000 (+0200) Subject: Always end functions with return. X-Git-Tag: 0.04~11 X-Git-Url: https://ruderich.org/simon/gitweb/?a=commitdiff_plain;h=fbfa7bab6a0c7f1705ca56a37b1ccc1d5d3c5288;p=blhc%2Fblhc.git Always end functions with return. Found by perlcritic. --- diff --git a/bin/blhc b/bin/blhc index e03ac28..9525baa 100755 --- a/bin/blhc +++ b/bin/blhc @@ -319,6 +319,8 @@ sub error_flags { printf '%s (%s)%s %s', error_color($message, 'red'), $flags, error_color(':', 'yellow'), $line; + + return; } sub error_non_verbose_build { my ($line) = @_; @@ -327,6 +329,8 @@ sub error_non_verbose_build { error_color('NONVERBOSE BUILD', 'red'), error_color(':', 'yellow'), $line; + + return; } sub error_invalid_cmake { my ($version) = @_; @@ -335,12 +339,16 @@ sub error_invalid_cmake { error_color('INVALID CMAKE', 'red'), error_color(':', 'yellow'), $version; + + return; } sub error_hardening_wrapper { printf "%s%s %s\n", error_color('HARDENING WRAPPER', 'red'), error_color(':', 'yellow'), 'no checks possible, aborting'; + + return; } sub error_color { my ($message, $color) = @_; @@ -477,6 +485,8 @@ sub remove_flags { or not exists $removes{$flag_renames_ref->{$_}}) } @{$flags}; } + + return; } sub compile_flag_regexp {