From 5b89dd9a588526e83fe43ca54c3caec96fca9575 Mon Sep 17 00:00:00 2001 From: Simon Ruderich Date: Sun, 11 Mar 2012 23:01:04 +0100 Subject: [PATCH] src/connection.c,src/verify.c: Use a constant for path length. --- src/connection.c | 4 ++-- src/tlsproxy.h | 2 ++ src/verify.c | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/connection.c b/src/connection.c index e4b0b29..4e98f30 100644 --- a/src/connection.c +++ b/src/connection.c @@ -199,7 +199,7 @@ void handle_connection(int client_socket) { * certificate then just pass through the connection and let the client * verify the server certificate. */ if (global_passthrough_unknown) { - char path[1024]; + char path[TLSPROXY_MAX_PATH_LENGTH]; FILE *file = NULL; if (-2 == server_certificate_file(&file, host, path, sizeof(path))) { @@ -353,7 +353,7 @@ static int initialize_tls_session_client(int peer_socket, gnutls_certificate_credentials_t *x509_cred) { int result; int use_invalid_cert; - char path[1024]; + char path[TLSPROXY_MAX_PATH_LENGTH]; /* The "invalid" hostname is special. If it's used we send an invalid * certificate to let the client know something is wrong. */ diff --git a/src/tlsproxy.h b/src/tlsproxy.h index 970b08d..59b4a70 100644 --- a/src/tlsproxy.h +++ b/src/tlsproxy.h @@ -31,6 +31,8 @@ #include "log.h" +/* Length for path arrays. */ +#define TLSPROXY_MAX_PATH_LENGTH 1024 /* Paths to necessary TLS files: the CA and the server key. */ #define PROXY_CA_FILE "proxy-ca.pem" diff --git a/src/verify.c b/src/verify.c index 0888a30..6697865 100644 --- a/src/verify.c +++ b/src/verify.c @@ -32,7 +32,7 @@ static int get_certificate_path(const char *format, int verify_tls_connection(gnutls_session_t session, const char *hostname) { int result; - char path[1024]; + char path[TLSPROXY_MAX_PATH_LENGTH]; size_t size; unsigned int status; -- 2.45.2