Fix false positives for comment lines

Closes Debian bug #825671.

diff --git a/NEWS b/NEWS
index a3c4c88b45231806a6d562629f7a980098d75f74..ffe3da037dc9877b1269d2c92d857cf75656875b 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -14,6 +14,8 @@ Version 0.XX
 - Sync architecture specific hardening support with dpkg 1.17.18.
 - Update t/tests.t for new output of Pod::Usage in 1.65 (Debian Bug #825428),
   reported by Niko Tyni, patch by Gregor Herrmann.
+- Fix false positives for comment lines (Debian Bug #825671), reported by
+  Fabian Wolff.
 
 
 Version 0.05

diff --git a/bin/blhc b/bin/blhc
index efb7f3b20aa6c98a812dfe8fcadcaa141d249c4d..4d2fb099cc70f72425791982b1c4ce1e528ccdac 100755 (executable)
--- a/bin/blhc
+++ b/bin/blhc
@@ -850,6 +850,7 @@ foreach my $file (@ARGV) {
             }
         }
 
+        next if $line =~ /^\s*#/;
         # Ignore compiler warnings for now.
         next if $line =~ /$warning_regex/o;
 

diff --git a/t/logs/false-positives b/t/logs/false-positives
index 8ef70d61ef5326829e28fe3dc4505827ae3b6d4b..c7487f7763e1c96bfc6364b4be94f8dadd8106a1 100644 (file)
--- a/t/logs/false-positives
+++ b/t/logs/false-positives
@@ -8,6 +8,9 @@ swig -Wall -c++ -python test.i
 
 rm -f afl-gcc afl-as afl-fuzz afl-showmap as afl-g++ afl-clang afl-clang++ *.o *~ a.out core core.[1-9][0-9]* *.stackdump test .test test-instr .test-instr0 .test-instr1
 
+# "Missing" flags in comments should be ignored.
+# gcc -E tag_tree.list does not work, so use a .c name
+
 # gcc -v can cause false positives.
 cd GUI && qmake
 /usr/bin/make -C GUI