X-Git-Url: https://ruderich.org/simon/gitweb/?p=coloredstderr%2Fcoloredstderr.git;a=blobdiff_plain;f=src%2Ftrackfds.h;h=c749f5e1d6f6cf142e5ce455888fb6d75c7eea58;hp=5720b0cca54cc6d159ec8d760d35ae5883878509;hb=8a65b4486febf00e3fad5bafc3773a811e675a4c;hpb=9ff0ffbd28416538a4ccc2445875339c7eb20dfe diff --git a/src/trackfds.h b/src/trackfds.h index 5720b0c..c749f5e 100644 --- a/src/trackfds.h +++ b/src/trackfds.h @@ -1,7 +1,7 @@ /* * Utility functions to track file descriptors. * - * Copyright (C) 2013 Simon Ruderich + * Copyright (C) 2013-2015 Simon Ruderich * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -50,6 +50,36 @@ static void tracked_fds_debug(void) { } #endif +/* Check if filename occurs in the comma-separated list ignore. */ +static int is_program_ignored(char const *filename, char const *ignore) { + size_t length; + size_t filename_length = strlen(filename); + +#ifdef DEBUG + debug(" is_program_ignored(\"%s\", \"%s\")\n", filename, ignore); +#endif + + for (; *ignore; ignore += length) { + while (*ignore == ',') { + ignore++; + } + + length = strcspn(ignore, ","); + if (length == 0) { + break; + } + + if (length != filename_length) { + continue; + } + if (!strncmp(filename, ignore, length)) { + return 1; + } + } + + return 0; +} + static int init_tracked_fds_list(size_t count) { assert(count > 0); @@ -69,12 +99,14 @@ static int init_tracked_fds_list(size_t count) { return 1; } -/* Load tracked file descriptors from the environment. The environment is used +/* + * Load tracked file descriptors from the environment. The environment is used * to pass the information to child processes. * * ENV_NAME_FDS and ENV_NAME_PRIVATE_FDS have the following format: Each * descriptor as string followed by a comma; there's a trailing comma. - * Example: "2,4,". */ + * Example: "2,4,". + */ static void init_from_environment(void) { #ifdef DEBUG debug("init_from_environment()\t\t[%d]\n", getpid()); @@ -88,6 +120,22 @@ static void init_from_environment(void) { initialized = 1; tracked_fds_list_count = 0; + /* Don't color writes to stderr for this binary (and its children) if it's + * contained in the comma-separated list in ENV_NAME_IGNORED_BINARIES. */ + env = getenv(ENV_NAME_IGNORED_BINARIES); + if (env) { + char path[512]; + + /* TODO: Don't require /proc/. */ + ssize_t written = readlink("/proc/self/exe", path, sizeof(path) - 1); + if (written > 0) { + path[written] = 0; /* readlink() does not null-terminate! */ + if (is_program_ignored(path, env)) { + return; + } + } + } + /* If ENV_NAME_FORCE_WRITE is set and not empty, allow writes to a non-tty * device. Use with care! Mainly used for the test suite. */ env = getenv(ENV_NAME_FORCE_WRITE); @@ -139,10 +187,6 @@ static void init_from_environment(void) { goto next; } - if (i == count) { - break; - } - /* Replace ',' to null-terminate number for atoi(). */ *x = 0; @@ -360,7 +404,7 @@ inline static int tracked_fds_find(int fd) { return 0; } - if (fd < TRACKFDS_STATIC_COUNT) { + if (likely(fd < TRACKFDS_STATIC_COUNT)) { return tracked_fds[fd]; }