From 1c8b03162112d713f693d91cfd14b11dae5a0a51 Mon Sep 17 00:00:00 2001
From: Simon Ruderich <simon@ruderich.org>
Date: Mon, 10 Jun 2019 23:53:49 +0200
Subject: [PATCH] nss: Makefile: build libcash_test.so in tests/

Prevents accidentally copying the test library instead of the actual NSS
library.
---
 .gitignore   |  2 +-
 nss/Makefile | 20 ++++++++++----------
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/.gitignore b/.gitignore
index 263abf9..c350eb7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,8 +1,8 @@
 /filetype_string.go
-/nss/libcash_test.so
 /nss/libnss_cash.so.2
 /nss/tests/gr
 /nss/tests/group.nsscash
+/nss/tests/libcash_test.so
 /nss/tests/passwd.nsscash
 /nss/tests/pw
 /nsscash
diff --git a/nss/Makefile b/nss/Makefile
index bbc43ee..7dfe547 100644
--- a/nss/Makefile
+++ b/nss/Makefile
@@ -13,10 +13,10 @@ all: libnss_cash.so.2
 
 clean:
 	rm -f libnss_cash.so.2 \
-	    libcash_test.so tests/gr tests/pw \
+	    tests/libcash_test.so tests/gr tests/pw \
 	    tests/group.nsscash tests/passwd.nsscash
 
-libnss_cash.so.2 libcash_test.so: $(wildcard *.c) $(wildcard *.h)
+libnss_cash.so.2 tests/libcash_test.so: $(wildcard *.c) $(wildcard *.h)
 	$(CC) -o $@ -shared -fPIC -Wl,-soname,$@ \
 		$(CFLAGS) $(CPPFLAGS) $(LDFLAGS) \
 		file.c gr.c pw.c search.c \
@@ -26,12 +26,12 @@ libnss_cash.so.2 libcash_test.so: $(wildcard *.c) $(wildcard *.h)
 # Tests
 
 test: tests/gr tests/pw tests/group.nsscash tests/passwd.nsscash
-	LD_LIBRARY_PATH=. LD_PRELOAD= ./tests/gr
-	LD_LIBRARY_PATH=. LD_PRELOAD= ./tests/pw
+	LD_LIBRARY_PATH=./tests LD_PRELOAD= ./tests/gr
+	LD_LIBRARY_PATH=./tests LD_PRELOAD= ./tests/pw
 
-tests/%: tests/%.c libcash_test.so
+tests/%: tests/%.c tests/libcash_test.so
 	$(CC) -o $@ $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) \
-		$(TEST_CFLAGS) $(TEST_LDFLAGS) -L. \
+		$(TEST_CFLAGS) $(TEST_LDFLAGS) -Ltests \
 		$< $(LDLIBS) -lcash_test -lasan
 
 tests/passwd.nsscash: tests/passwd
@@ -39,9 +39,9 @@ tests/passwd.nsscash: tests/passwd
 tests/group.nsscash: tests/group
 	../nsscash convert group $< $@
 
-libcash_test.so: CFLAGS += $(TEST_CFLAGS)
-libcash_test.so: CPPFLAGS += -DNSSCASH_GROUP_FILE='"./tests/group.nsscash"' \
-                             -DNSSCASH_PASSWD_FILE='"./tests/passwd.nsscash"'
-libcash_test.so: LDFLAGS += $(TEST_LDFLAGS)
+tests/libcash_test.so: CFLAGS += $(TEST_CFLAGS)
+tests/libcash_test.so: CPPFLAGS += -DNSSCASH_GROUP_FILE='"./tests/group.nsscash"' \
+                                   -DNSSCASH_PASSWD_FILE='"./tests/passwd.nsscash"'
+tests/libcash_test.so: LDFLAGS += $(TEST_LDFLAGS)
 
 .PHONY: all clean test
-- 
2.43.2