X-Git-Url: https://ruderich.org/simon/gitweb/?p=ptyas%2Fptyas.git;a=blobdiff_plain;f=ptyas.c;h=25f49aa2fc81ebb3d935ec87403857d8606a25a2;hp=9fc7997269a23b756f8a173f399f8bbad771df26;hb=09096d9ba0eb9bc938b7bd050a89abd949bf7257;hpb=dad601b98c99c7597d7d6e1df85028d884051a90 diff --git a/ptyas.c b/ptyas.c index 9fc7997..25f49aa 100644 --- a/ptyas.c +++ b/ptyas.c @@ -2,20 +2,20 @@ * Run the login shell or command as the given user in a new pty to prevent * terminal injection attacks. * - * Copyright (C) 2016-2018 Simon Ruderich + * Copyright (C) 2016-2019 Simon Ruderich * * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by + * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. + * GNU Affero General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . */ #define _GNU_SOURCE @@ -286,6 +286,28 @@ static void sigchld_handler(int signal) { } } +/* + * SIGWINCH handler to handle resizes of the outer terminal. + * + * Errors are ignored without message because printing in signal handlers is + * problematic (no FILE * usable due to locks) and there's not much we can do + * at this point. + */ +static int sigwinch_ctty = -1; +static int sigwinch_slave = -1; + +static void sigwinch_handler(int signal) { + (void)signal; + + struct winsize size; + if (ioctl(sigwinch_ctty, TIOCGWINSZ, &size) == -1) { + return; + } + if (ioctl(sigwinch_slave, TIOCSWINSZ, &size) == -1) { + return; + } +} + int main(int argc, char **argv) { char *exec_argv_shell[] = { NULL, NULL }; /* filled below */ @@ -422,14 +444,26 @@ int main(int argc, char **argv) { } quit_with_matching_code(status); } - close_or_die(pty_slave); + /* Don't close pty_slave here as it's used in sigwinch_handler(). */ + + sigwinch_ctty = ctty; + sigwinch_slave = pty_slave; + + struct sigaction action_sigwinch = { + .sa_handler = sigwinch_handler, + }; + sigemptyset(&action_sigwinch.sa_mask); + if (sigaction(SIGWINCH, &action_sigwinch, NULL) != 0) { + die("sigaction SIGWINCH"); + } pid_to_wait_for = pid; - struct sigaction action = { + struct sigaction action_sigchld = { .sa_handler = sigchld_handler, }; - if (sigaction(SIGCHLD, &action, NULL) != 0) { - die("sigaction"); + sigemptyset(&action_sigchld.sa_mask); + if (sigaction(SIGCHLD, &action_sigchld, NULL) != 0) { + die("sigaction SIGCHLD"); } if (sigprocmask(SIG_SETMASK, &sigset_old, NULL) != 0) {