X-Git-Url: https://ruderich.org/simon/gitweb/?p=ptyas%2Fptyas.git;a=blobdiff_plain;f=ptyas.c;h=ab99f8ede71cf352d4d7aa2ef9c2af83a5b4ef06;hp=05170ec9ed7fd04f534476dfb2cae3bd307ea08a;hb=c8ffdb4777654018284c63d7824efca50e5d65b7;hpb=328d6d4cd65cd724297052818f3138a005e9a65e

diff --git a/ptyas.c b/ptyas.c
index 05170ec..ab99f8e 100644
--- a/ptyas.c
+++ b/ptyas.c
@@ -2,7 +2,7 @@
  * Run the login shell or command as the given user in a new pty to prevent
  * terminal injection attacks.
  *
- * Copyright (C) 2016  Simon Ruderich
+ * Copyright (C) 2016-2017  Simon Ruderich
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -39,6 +39,12 @@
 #include <termios.h>
 #include <unistd.h>
 
+/* Default PATH for new process.*/
+#ifndef PTYAS_DEFAULT_PATH
+/* Default user PATH from Debian's /etc/profile, change as needed. */
+# define PTYAS_DEFAULT_PATH "/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games"
+#endif
+
 
 static void die(const char *s) {
     perror(s);
@@ -79,7 +85,6 @@ static void open_pty_or_die(int *pty_master, int *pty_slave, uid_t uid) {
     /* The user must be able to write to the new TTY. Normally grantpt() would
      * do this for us, but we don't trust the user and thus don't want to pass
      * the pty_master to a process running under that uid. */
-    // TODO: is this a problem?
     if (chown(slave_path, uid, (gid_t)-1) != 0) {
         die("chown slave tty");
     }
@@ -114,7 +119,7 @@ static void drop_privileges_or_die(uid_t uid, gid_t gid) {
         die("setgroups");
     }
     if (getgroups(0, NULL) != 0) {
-        die_fmt("failed to drop all groups");
+        die_fmt("failed to drop all supplementary groups");
     }
 
     /* Dropping groups may require privileges, do that first. */
@@ -206,7 +211,7 @@ static void proxy_input_between_ttys(int pty_master, int ctty, volatile pid_t *p
     while (*pid_to_wait_for != 0) {
         /*
          * If a signal happens here _and_ the child hasn't closed pty_slave,
-         * we will hang in poll(); therefore ppoll() is requred.
+         * we would hang in poll(); therefore ppoll() is necessary.
          */
         nfds_t nfds = sizeof(fds)/sizeof(*fds);
         if (ppoll(fds, nfds, NULL /* no timeout */, &sigset_old) == -1) {
@@ -218,7 +223,8 @@ static void proxy_input_between_ttys(int pty_master, int ctty, volatile pid_t *p
             break;
         }
 
-        /* Handle errors first. */
+        /* Handle errors first. (Data available before the error occurred
+         * might be skipped, but shouldn't matter here.) */
         if (fds[0].revents & (POLLERR | POLLNVAL)) {
             fprintf(stderr, "poll: error on master: %d\n", fds[0].revents);
             break;
@@ -228,7 +234,7 @@ static void proxy_input_between_ttys(int pty_master, int ctty, volatile pid_t *p
             break;
         }
 
-        /* Then read data if available. */
+        /* Read data if available. */
         if (fds[0].revents & POLLIN) {
             if (!read_from_write_to(pty_master, ctty)) {
                 perror("read from master write to ctty");
@@ -254,7 +260,10 @@ static void proxy_input_between_ttys(int pty_master, int ctty, volatile pid_t *p
 }
 
 
-/* Not sig_atomic_t but I don't know how to do that any other way. */
+/*
+ * Not sig_atomic_t (as required by POSIX) but I don't know how to do that any
+ * other way.
+ */
 static volatile pid_t pid_to_wait_for;
 static int pid_to_wait_for_status;
 
@@ -321,6 +330,8 @@ int main(int argc, char **argv) {
     if (pid == -1) {
         die("fork parent");
     } else if (pid == 0) {
+        /* child, will become a session leader */
+
         if (sigprocmask(SIG_SETMASK, &sigset_old, NULL) != 0) {
             die("sigprocmask setmask child");
         }
@@ -371,7 +382,7 @@ int main(int argc, char **argv) {
             snprintf_or_assert(envp_term, sizeof(envp_term), "TERM=%s", term);
 
             char *exec_envp[] = {
-                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
+                "PATH=" PTYAS_DEFAULT_PATH,
                 envp_user,
                 envp_home,
                 term_orig ? envp_term : NULL,
@@ -386,7 +397,7 @@ int main(int argc, char **argv) {
         close_or_die(STDOUT_FILENO);
         close_or_die(STDERR_FILENO);
 
-        // TODO: EINTR?
+        /* TODO: EINTR? */
         int status;
         if (waitpid(pid, &status, 0) <= 0) {
             die("waitpid child");
@@ -414,7 +425,7 @@ int main(int argc, char **argv) {
         die("tcgetattr");
     }
     term = old_term;
-    /* From man 3 cfmakeraw which is non-standard. */
+    /* From man 3 cfmakeraw; cfmakeraw is non-standard so set it manually. */
     term.c_iflag &= ~(tcflag_t)(IGNBRK | BRKINT | PARMRK | ISTRIP | INLCR | IGNCR | ICRNL | IXON);
     term.c_oflag &= ~(tcflag_t)(OPOST);
     term.c_lflag &= ~(tcflag_t)(ECHO | ECHONL | ICANON | ISIG | IEXTEN);