From 2bd62914a0887c368ddba71f0fbcd0a01084b4b6 Mon Sep 17 00:00:00 2001 From: Simon Ruderich Date: Tue, 5 Oct 2021 10:50:40 +0200 Subject: [PATCH 1/1] Add support for FreeBSD Tested on FreeBSD 13.0-RELEASE-p4 but should work on all relevant versions. --- ptyas.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/ptyas.c b/ptyas.c index dc5f3de..e8e1ba7 100644 --- a/ptyas.c +++ b/ptyas.c @@ -117,12 +117,29 @@ static int snprintf_or_assert(char *str, size_t size, const char *format, ...) { static void drop_privileges_or_die(uid_t uid, gid_t gid) { /* Drop all supplementary group IDs. */ +#ifdef __FreeBSD__ + { + /* FreeBSD uses the first gid to set the egid of the process. */ + gid_t egid = gid; + if (setgroups(1, &egid) != 0) { + die("setgroups"); + } + if (getgroups(1, &egid) != 1) { + die_fmt("failed to drop all supplementary groups\n"); + } + if (egid != gid) { + die_fmt("failed to drop all supplementary groups (egid): %d %d\n", + egid, gid); + } + } +#else if (setgroups(0, NULL) != 0) { die("setgroups"); } if (getgroups(0, NULL) != 0) { die_fmt("failed to drop all supplementary groups\n"); } +#endif /* Dropping groups may require privileges, do that first. */ if (setresgid(gid, gid, gid) != 0) { -- 2.43.2