X-Git-Url: https://ruderich.org/simon/gitweb/?p=safcm%2Fsafcm.git;a=blobdiff_plain;f=rpc%2Fdial.go;h=0782ab08e617933e4e2c369651253d11324e355f;hp=945a75ff86c365fd1e251e205a0b68efbd2b3aef;hb=5d6cc7f14a4bacc36bf3a23cd735a75ad4a90f1d;hpb=d56dba0752e6b7d2dcac2c0d0e2e3ccddf80cd2a diff --git a/rpc/dial.go b/rpc/dial.go index 945a75f..0782ab0 100644 --- a/rpc/dial.go +++ b/rpc/dial.go @@ -141,13 +141,13 @@ compat_sha512sum() { // // The target directory must no permit other users to delete our files // or symlink attacks and arbitrary code execution is possible. For - // /tmp this is guaranteed by the sticky bit. Make sure it has the - // proper permissions. + // /tmp this is guaranteed by the sticky bit. The code verifies the + // directory has the proper permissions. // // We cannot use `test -f && test -O` because this is open to TOCTOU // attacks. `stat` gives use the full file state. If the file is owned - // by us and not a symlink then it's safe to use (assuming sticky or - // directory not writable by others). + // by us and not a symlink then it's safe to use (assuming sticky + // directory or directory not writable by others). // // `test -e` is only used to prevent error messages if the file // doesn't exist. It does not guard against any races. @@ -264,7 +264,7 @@ f c.sshRemote, fmt.Sprintf("cat > %q", path))...) cmd.Stdin = bytes.NewReader(helper) - err = c.handleStderrAsEvents(cmd) + err = c.handleStderrAsEvents(cmd) // cmd.Stderr if err != nil { return err }