From e73d568e9135bce2343ed295b632c2dcb0313859 Mon Sep 17 00:00:00 2001
From: Simon Ruderich <simon@ruderich.org>
Date: Mon, 7 Mar 2011 06:33:05 +0100
Subject: [PATCH] src/tlsproxy.c: Improve command line argument error messages.

---
 src/tlsproxy.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/tlsproxy.c b/src/tlsproxy.c
index 70cf49d..9c3b53c 100644
--- a/src/tlsproxy.c
+++ b/src/tlsproxy.c
@@ -76,7 +76,7 @@ int main(int argc, char **argv) {
     port = atoi(argv[argc - 1]);
     if (0 >= port || 0xffff < port) {
         print_usage(argv[0]);
-        fprintf(stderr, "\ninvalid port");
+        fprintf(stderr, "\ninvalid port\n");
         return EXIT_FAILURE;
     }
 
@@ -227,7 +227,8 @@ static void parse_arguments(int argc, char **argv) {
                         || 0 == strlen(position + 1)
                         || 0 >= atoi(position + 1)
                         || 0xffff < atoi(position + 1)) {
-                    fprintf(stderr, "-p host:port\n");
+                    print_usage(argv[0]);
+                    fprintf(stderr, "\ninvalid -p, format host:port\n");
                     exit(EXIT_FAILURE);
                 }
 
@@ -250,7 +251,8 @@ static void parse_arguments(int argc, char **argv) {
             }
             case 't': {
                 if (0 >= atoi(optarg)) {
-                    fprintf(stderr, "-t positive number required\n");
+                    print_usage(argv[0]);
+                    fprintf(stderr, "\n-t positive number required\n");
                     exit(EXIT_FAILURE);
                 }
                 thread_count = (size_t)atoi(optarg);
@@ -265,6 +267,7 @@ static void parse_arguments(int argc, char **argv) {
 
     if (optind >= argc) {
         print_usage(argv[0]);
+        fprintf(stderr, "\nport missing\n");
         exit(EXIT_FAILURE);
     }
 }
-- 
2.44.1