"encoding/binary"
"fmt"
"io"
+ "math"
"sort"
"strconv"
"strings"
t, err := s.ReadString('\n')
if err != nil {
if err == io.EOF {
+ if t != "" {
+ return nil, fmt.Errorf(
+ "no newline in last line: %q",
+ t)
+ }
break
}
return nil, err
return res, nil
}
-func SerializeGroup(g Group) []byte {
+func SerializeGroup(g Group) ([]byte, error) {
le := binary.LittleEndian
// Concatenate all (NUL-terminated) strings and store the offsets
}
// And the group members concatenated as above
data.Write(mems.Bytes())
+ // Ensure the offsets can fit the length of this entry
+ if data.Len() > math.MaxUint16 {
+ return nil, fmt.Errorf("group too large to serialize: %v, %v",
+ data.Len(), g)
+ }
size := uint16(data.Len())
var res bytes.Buffer // serialized result
// struct are 8 byte aligned
alignBufferTo(&res, 8)
- return res.Bytes()
+ return res.Bytes(), nil
}
func SerializeGroups(w io.Writer, grs []Group) error {
for _, g := range grs {
// TODO: warn about duplicate entries
offsets[toKey(g)] = uint64(data.Len())
- data.Write(SerializeGroup(g))
+ x, err := SerializeGroup(g)
+ if err != nil {
+ return err
+ }
+ data.Write(x)
}
// Copy to prevent sorting from modifying the argument