#include "connection.h"
#include "verify.h"
-/* close() */
-#include <unistd.h>
-/* getaddrinfo() */
+#include <errno.h>
#include <netdb.h>
-/* poll() */
#include <poll.h>
-/* errno */
-#include <errno.h>
+#include <unistd.h>
/* Maximum length of a HTTP request line. Longer request lines are aborted
}
/* Check response of proxy server. */
- if (strncmp(buffer, "HTTP/1.0 200", 12) != 0) {
+ if (strncmp(buffer, "HTTP/1.0 200", 12)) {
LOG(LOG_WARNING, "bad proxy response: %s", buffer);
send_forwarding_failure(client_fd);
goto out;
out:
/* Close TLS sessions if necessary. Use GNUTLS_SHUT_RDWR so the data is
* reliable transmitted. */
- if (server_session_started != 0) {
+ if (server_session_started) {
gnutls_bye(server_session, GNUTLS_SHUT_RDWR);
}
- if (client_session_started != 0) {
+ if (client_session_started) {
gnutls_bye(client_session, GNUTLS_SHUT_RDWR);
}
- if (server_session_init != 0) {
+ if (server_session_init) {
gnutls_deinit(server_session);
gnutls_certificate_free_credentials(server_x509_cred);
}
- if (client_session_init != 0) {
+ if (client_session_init) {
gnutls_deinit(client_session);
gnutls_certificate_free_cas(client_x509_cred);
gnutls_certificate_free_keys(client_x509_cred);
/* The "invalid" hostname is special. If it's used we send an invalid
* certificate to let the client know something is wrong. */
- use_invalid_cert = (strcmp(hostname, "invalid") == 0);
+ use_invalid_cert = (!strcmp(hostname, "invalid"));
if (proxy_certificate_path(hostname, path, sizeof(path)) != 0) {
LOG(LOG_ERROR,
while (fgets(buffer, sizeof(buffer), client_fd) != NULL) {
/* End of header. */
- if (strcmp(buffer, "\n") == 0 || strcmp(buffer, "\r\n") == 0) {
+ if (!strcmp(buffer, "\n") || !strcmp(buffer, "\r\n")) {
break;
}
}
char *position;
/* scanf() doesn't check spaces. */
- if (strncmp(request, "CONNECT ", 8) != 0) {
+ if (strncmp(request, "CONNECT ", 8)) {
return -1;
}
/* Check request and extract data, "host:port" is not yet separated. */