* ensures the server certificate doesn't change. Normally this isn't detected
* if a trusted CA for the new server certificate is installed.
*
- * Copyright (C) 2011-2012 Simon Ruderich
+ * Copyright (C) 2011-2013 Simon Ruderich
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
#include "sem.h"
#include "connection.h"
-/* socket(), bind(), accept(), listen() */
-#include <sys/types.h>
-#include <sys/socket.h>
-/* close() */
-#include <unistd.h>
-/* htons() */
#include <arpa/inet.h>
-/* sigaction() */
-#include <signal.h>
-/* errno */
#include <errno.h>
-/* pthread_*() */
#include <pthread.h>
+#include <signal.h>
+#include <sys/socket.h>
+#include <sys/types.h>
+#include <unistd.h>
-/* For GnuTLS. */
+/* Necessary for GnuTLS when used with threads. */
#include <gcrypt.h>
-
GCRY_THREAD_OPTION_PTHREAD_IMPL;
/* For gnutls_*() functions. */
#define GNUTLS_ERROR_EXIT(error, message) \
- if (GNUTLS_E_SUCCESS != error) { \
+ if (error != GNUTLS_E_SUCCESS) { \
fprintf(stderr, "%s: %s\n", message, gnutls_strerror(error)); \
exit(EXIT_FAILURE); \
}
static void initialize_gnutls(void);
static void deinitialize_gnutls(void);
-static void worker_thread(void);
+static void *worker_thread(void *unused);
int main(int argc, char **argv) {
parse_arguments(argc, argv);
port = atoi(argv[argc - 1]);
- if (0 >= port || 0xffff < port) {
+ if (port <= 0 || port > 0xffff ) {
print_usage(argv[0]);
- fprintf(stderr, "\ninvalid port\n");
+ fprintf(stderr, "\ninvalid port: '%s'\n", argv[argc - 1]);
return EXIT_FAILURE;
}
/* Spawn worker threads to handle requests. */
threads = malloc(thread_count * sizeof(*threads));
- if (NULL == threads) {
+ if (threads == NULL) {
perror("thread malloc failed");
return EXIT_FAILURE;
}
for (i = 0; i < thread_count; i++) {
- int result;
- pthread_t thread;
-
- result = pthread_create(&thread, NULL,
- (void * (*)(void *))&worker_thread,
- NULL);
- if (0 != result) {
- fprintf(stderr, "failed to create worker thread: %s\n",
- strerror(result));
+ errno = pthread_create(threads + i, NULL, &worker_thread, NULL);
+ if (errno != 0) {
+ perror("failed to create worker thread");
return EXIT_FAILURE;
}
-
- threads[i] = thread;
}
#ifdef USE_IPV4_ONLY
#else
server_socket = socket(PF_INET6, SOCK_STREAM, 0);
#endif
- if (-1 == server_socket) {
+ if (server_socket == -1) {
perror("socket()");
return EXIT_FAILURE;
}
/* Fast rebinding for debug mode, could cause invalid packets. */
- if (LOG_DEBUG_LEVEL <= global_log_level) {
+ if (global_log_level >= LOG_DEBUG_LEVEL) {
int socket_option = 1;
setsockopt(server_socket, SOL_SOCKET, SO_REUSEADDR,
&socket_option, sizeof(socket_option));
server_in.sin6_addr = in6addr_any; /* bind to any address */
server_in.sin6_port = htons((uint16_t)port); /* port to bind to */
#endif
- if (-1 == bind(server_socket, (struct sockaddr *)&server_in,
- sizeof(server_in))) {
+ if (bind(server_socket, (struct sockaddr *)&server_in,
+ sizeof(server_in)) == -1) {
perror("bind()");
return EXIT_FAILURE;
}
/* And accept connections. */
- if (-1 == listen(server_socket, 5)) {
+ if (listen(server_socket, 5) == -1) {
perror("listen()");
return EXIT_FAILURE;
}
- if (LOG_DEBUG_LEVEL <= global_log_level) {
+ if (global_log_level >= LOG_DEBUG_LEVEL) {
printf("tlsproxy %s\n", VERSION);
printf("Listening for connections on port %d.\n", port);
- if (NULL != global_proxy_host && NULL != global_proxy_port) {
+ if (global_proxy_host != NULL && global_proxy_port != NULL) {
printf("Using proxy: %s:%s.\n", global_proxy_host,
global_proxy_port);
}
while (!done) {
/* Accept new connection. */
client_socket = accept(server_socket, NULL, NULL);
- if (-1 == client_socket) {
+ if (client_socket == -1) {
perror("accept()");
break;
}
}
for (i = 0; i < thread_count; i++) {
errno = pthread_join(threads[i], NULL);
- if (0 != errno) {
+ if (errno != 0) {
perror("pthread_join()");
}
}
#endif
global_passthrough_unknown = 0;
- while (-1 != (option = getopt(argc, argv, "d:p:t:uh?"))) {
+ while ((option = getopt(argc, argv, "d:p:t:uh?")) != -1) {
switch (option) {
case 'd': {
- if (0 > atoi(optarg)) {
+ global_log_level = atoi(optarg);
+ if (global_log_level < 0) {
print_usage(argv[0]);
- fprintf(stderr, "\n-d positive number required\n");
+ fprintf(stderr, "\n-d positive number required: '%s'\n",
+ optarg);
exit(EXIT_FAILURE);
}
- global_log_level = atoi(optarg);
break;
}
case 'p': {
char *position;
/* -p must have the format host:port. */
- if (NULL == (position = strchr(optarg, ':'))
- || position == optarg
- || 0 == strlen(position + 1)
- || 0 >= atoi(position + 1)
- || 0xffff < atoi(position + 1)) {
+ if ((position = strchr(optarg, ':')) == NULL
+ || optarg == position
+ || strlen(position + 1) == 0
+ || atoi(position + 1) <= 0
+ || atoi(position + 1) > 0xffff) {
print_usage(argv[0]);
- fprintf(stderr, "\ninvalid -p, format host:port\n");
+ fprintf(stderr, "\ninvalid -p: '%s', format host:port\n",
+ optarg);
exit(EXIT_FAILURE);
}
global_proxy_host = malloc((size_t)(position - optarg) + 1);
- if (NULL == global_proxy_host) {
+ if (global_proxy_host == NULL) {
perror("malloc()");
exit(EXIT_FAILURE);
}
global_proxy_host[position - optarg] = '\0';
global_proxy_port = malloc(strlen(position + 1) + 1);
- if (NULL == global_proxy_port) {
+ if (global_proxy_port == NULL) {
perror("malloc()");
exit(EXIT_FAILURE);
}
break;
}
case 't': {
- if (0 >= atoi(optarg)) {
+ if (atoi(optarg) <= 0) {
print_usage(argv[0]);
- fprintf(stderr, "\n-t positive number required\n");
+ fprintf(stderr, "\n-t positive number required: '%s'\n",
+ optarg);
exit(EXIT_FAILURE);
}
thread_count = (size_t)atoi(optarg);
static void initialize_gnutls(void) {
int result;
- gcry_error_t error = 0;
+ gcry_error_t error;
/* Thread safe setup. Must be called before gnutls_global_init(). */
error = gcry_control(GCRYCTL_SET_THREAD_CBS, &gcry_threads_pthread);
- if (error) {
+ if (error != 0) {
fprintf(stderr, "gcry_control(): %s/%s\n", gcry_strsource(error),
gcry_strerror(error));
exit(EXIT_FAILURE);
}
/* Prevent usage of blocking /dev/random. */
error = gcry_control(GCRYCTL_ENABLE_QUICK_RANDOM, 0);
- if (error) {
+ if (error != 0) {
fprintf(stderr, "gcry_control(): %s/%s\n", gcry_strsource(error),
gcry_strerror(error));
exit(EXIT_FAILURE);
gnutls_global_deinit();
}
-static void worker_thread(void) {
+static void *worker_thread(void *unused) {
int client_socket;
+ (void)unused;
+
for (;;) {
/* Get next element from ring buffer. */
P(ringbuffer_full);
V(ringbuffer_free);
/* Negative value indicates we should shut down our thread. */
- if (0 > client_socket) {
+ if (client_socket < 0) {
break;
}
handle_connection(client_socket);
}
+
+ return NULL;
}