X-Git-Url: https://ruderich.org/simon/gitweb/?a=blobdiff_plain;f=cmd%2Fsafcm%2Fsync_test.go;h=d4b0e7ce9c8c0653d6b887c2fd40ce9a246902ca;hb=refs%2Fheads%2Fmaster;hp=4616f716a28d75f5967e3654b02f2ede81331c84;hpb=3473766d8afb07cb0685694656947883cbbd1138;p=safcm%2Fsafcm.git

diff --git a/cmd/safcm/sync_test.go b/cmd/safcm/sync_test.go
index 4616f71..d4b0e7c 100644
--- a/cmd/safcm/sync_test.go
+++ b/cmd/safcm/sync_test.go
@@ -1,17 +1,5 @@
-// Copyright (C) 2021  Simon Ruderich
-//
-// This program is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// This program is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with this program.  If not, see <http://www.gnu.org/licenses/>.
+// SPDX-License-Identifier: GPL-3.0-or-later
+// Copyright (C) 2021-2024  Simon Ruderich
 
 package main
 
@@ -29,7 +17,7 @@ func TestHostsToSync(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	defer os.Chdir(cwd)
+	defer os.Chdir(cwd) //nolint:errcheck
 
 	err = os.Chdir("testdata/project")
 	if err != nil {
@@ -40,6 +28,12 @@ func TestHostsToSync(t *testing.T) {
 		t.Fatal(err)
 	}
 
+	const errMsg = `
+
+Groups depending on "detected" groups cannot be used to select hosts as these
+are only available after the hosts were contacted.
+`
+
 	tests := []struct {
 		name   string
 		names  []string
@@ -100,7 +94,7 @@ func TestHostsToSync(t *testing.T) {
 
 		{
 			"group: single name",
-			[]string{"group"},
+			[]string{"group3"},
 			[]*config.Host{
 				allHosts.Map["host1.example.org"],
 			},
@@ -108,7 +102,7 @@ func TestHostsToSync(t *testing.T) {
 		},
 		{
 			"group: multiple names",
-			[]string{"group", "group2"},
+			[]string{"group3", "group2"},
 			[]*config.Host{
 				allHosts.Map["host1.example.org"],
 				allHosts.Map["host2"],
@@ -117,7 +111,7 @@ func TestHostsToSync(t *testing.T) {
 		},
 		{
 			"group: multiple identical names",
-			[]string{"group", "group2", "group"},
+			[]string{"group3", "group2", "group3"},
 			[]*config.Host{
 				allHosts.Map["host1.example.org"],
 				allHosts.Map["host2"],
@@ -126,7 +120,7 @@ func TestHostsToSync(t *testing.T) {
 		},
 		{
 			"group: multiple names, including unknown",
-			[]string{"group", "group2", "unknown-group"},
+			[]string{"group3", "group2", "unknown-group"},
 			nil,
 			fmt.Errorf("hosts/groups not found: \"unknown-group\""),
 		},
@@ -141,6 +135,19 @@ func TestHostsToSync(t *testing.T) {
 			nil,
 		},
 
+		{
+			"group: single name (detected)",
+			[]string{"group"},
+			nil,
+			fmt.Errorf(`group "group" depends on "detected" groups` + errMsg),
+		},
+		{
+			"group: multiple names (detected)",
+			[]string{"group", "group2"},
+			nil,
+			fmt.Errorf(`group "group" depends on "detected" groups` + errMsg),
+		},
+
 		{
 			"\"all\" and name",
 			[]string{"all", "group2"},