X-Git-Url: https://ruderich.org/simon/gitweb/?a=blobdiff_plain;f=src%2Ftlsproxy.c;h=86ee227e142a762a7bc8ca7ed8898829da9b5b32;hb=5b89dd9a588526e83fe43ca54c3caec96fca9575;hp=625ed0803e93fc05d96bed988d85c98c052e79b5;hpb=a6880da1a7e80f74bed1caf0d2ed6e9034ea2245;p=tlsproxy%2Ftlsproxy.git

diff --git a/src/tlsproxy.c b/src/tlsproxy.c
index 625ed08..86ee227 100644
--- a/src/tlsproxy.c
+++ b/src/tlsproxy.c
@@ -3,7 +3,7 @@
  * ensures the server certificate doesn't change. Normally this isn't detected
  * if a trusted CA for the new server certificate is installed.
  *
- * Copyright (C) 2011  Simon Ruderich
+ * Copyright (C) 2011-2012  Simon Ruderich
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -109,11 +109,11 @@ int main(int argc, char **argv) {
         return EXIT_FAILURE;
     }
 
-    /* Setup our SIGINT signal handler which allows a "normal" termination of
-     * the server in DEBUG mode. */
     sigemptyset(&action.sa_mask);
     action.sa_flags   = 0;
 #ifdef DEBUG
+    /* Setup our SIGINT signal handler which allows a "normal" termination of
+     * the server in DEBUG mode. */
     action.sa_handler = sigint_handler;
     sigaction(SIGINT, &action, NULL);
 #endif
@@ -137,7 +137,7 @@ int main(int argc, char **argv) {
     initialize_gnutls();
 
     /* Spawn worker threads to handle requests. */
-    threads = (pthread_t *)malloc(thread_count * sizeof(pthread_t));
+    threads = malloc(thread_count * sizeof(*threads));
     if (NULL == threads) {
         perror("thread malloc failed");
         return EXIT_FAILURE;
@@ -169,7 +169,7 @@ int main(int argc, char **argv) {
     }
 
     /* Fast rebinding for debug mode, could cause invalid packets. */
-    if (LOG_DEBUG <= global_log_level) {
+    if (LOG_DEBUG_LEVEL <= global_log_level) {
         int socket_option = 1;
         setsockopt(server_socket, SOL_SOCKET, SO_REUSEADDR,
                    &socket_option, sizeof(socket_option));
@@ -197,7 +197,8 @@ int main(int argc, char **argv) {
         return EXIT_FAILURE;
     }
 
-    if (LOG_DEBUG <= global_log_level) {
+    if (LOG_DEBUG_LEVEL <= global_log_level) {
+        printf("tlsproxy %s\n", VERSION);
         printf("Listening for connections on port %d.\n", port);
 
         if (NULL != global_proxy_host && NULL != global_proxy_port) {
@@ -214,7 +215,7 @@ int main(int argc, char **argv) {
             break;
         }
 
-        /* No lock, we only have one producer! */
+        /* No lock necessary, we only have one producer! */
         P(ringbuffer_free);
         ringbuffer[ringbuffer_write] = client_socket;
         ringbuffer_write = (ringbuffer_write + 1) % RINGBUFFER_SIZE;
@@ -234,7 +235,6 @@ int main(int argc, char **argv) {
         errno = pthread_join(threads[i], NULL);
         if (0 != errno) {
             perror("pthread_join()");
-            continue;
         }
     }
 
@@ -266,9 +266,9 @@ static void parse_arguments(int argc, char **argv) {
     /* Default values. */
     thread_count = 10;
 #ifdef DEBUG
-    global_log_level = LOG_DEBUG;
+    global_log_level = LOG_DEBUG_LEVEL;
 #else
-    global_log_level = LOG_WARNING;
+    global_log_level = LOG_WARNING_LEVEL;
 #endif
     global_passthrough_unknown = 0;
 
@@ -341,6 +341,8 @@ static void parse_arguments(int argc, char **argv) {
     }
 }
 static void print_usage(const char *argv) {
+    fprintf(stderr, "tlsproxy %s, a certificate checking TLS proxy\n",
+                    VERSION);
     fprintf(stderr, "Usage: %s [-d level] [-p host:port] [-t count] [-u] port\n",
                     argv);
     fprintf(stderr, "\n");