X-Git-Url: https://ruderich.org/simon/gitweb/?a=blobdiff_plain;f=src%2Fverify.c;h=6697865d01a9c02167b3b2449a61c2b90f9d38a3;hb=5b89dd9a588526e83fe43ca54c3caec96fca9575;hp=1df9b511686b8e2f17447513ffe45e53c1f7c434;hpb=718112774884f6b9420d55b506bcdc85012ca366;p=tlsproxy%2Ftlsproxy.git

diff --git a/src/verify.c b/src/verify.c
index 1df9b51..6697865 100644
--- a/src/verify.c
+++ b/src/verify.c
@@ -1,7 +1,7 @@
 /*
  * Verify established TLS connections.
  *
- * Copyright (C) 2011  Simon Ruderich
+ * Copyright (C) 2011-2012  Simon Ruderich
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -32,7 +32,7 @@ static int get_certificate_path(const char *format,
 
 int verify_tls_connection(gnutls_session_t session, const char *hostname) {
     int result;
-    char path[1024];
+    char path[TLSPROXY_MAX_PATH_LENGTH];
 
     size_t size;
     unsigned int status;
@@ -114,7 +114,7 @@ int verify_tls_connection(gnutls_session_t session, const char *hostname) {
     gnutls_x509_crt_deinit(cert);
 
     /* Open stored server certificate file. */
-    if (0 != server_certificate_path(&file, hostname, path, sizeof(path))) {
+    if (0 != server_certificate_file(&file, hostname, path, sizeof(path))) {
         LOG(LOG_DEBUG, "server certificate:\n%s", server_cert);
         return -1;
     }
@@ -156,6 +156,21 @@ int verify_tls_connection(gnutls_session_t session, const char *hostname) {
         return -2;
     }
 
+    /* Check that the proxy certificate file exists and is readable for this
+     * domain. This ensures we send an "invalid" certificate even if the proxy
+     * certificate doesn't exist. */
+    if (0 != proxy_certificate_path(hostname, path, sizeof(path))) {
+        return -1;
+    }
+    file = fopen(path, "r");
+    if (NULL == file) {
+        LOG(LOG_WARNING,
+            "verify_tls_connection(): proxy certificate doesn't exist: '%s'",
+            path);
+        return -1;
+    }
+    fclose(file);
+
     return 0;
 }
 
@@ -196,12 +211,12 @@ int proxy_certificate_path(const char *hostname, char *path, size_t size) {
                                 hostname, path, size);
 }
 
-int server_certificate_path(FILE **file, const char *hostname,
+int server_certificate_file(FILE **file, const char *hostname,
                             char *path, size_t size) {
     if (0 != get_certificate_path(STORED_SERVER_CERT_FORMAT,
                                   hostname, path, size)) {
         LOG_PERROR(LOG_ERROR,
-                   "server_certificate_path(): failed to get path");
+                   "server_certificate_file(): failed to get path");
         return -1;
     }
 
@@ -210,11 +225,11 @@ int server_certificate_path(FILE **file, const char *hostname,
     if (NULL == *file) {
         if (global_passthrough_unknown) {
             LOG(LOG_DEBUG,
-                "server_certificate_path(): failed to open '%s': %s",
+                "server_certificate_file(): failed to open '%s': %s",
                 path, strerror(errno));
         } else {
             LOG(LOG_WARNING,
-                "server_certificate_path(): failed to open '%s': %s",
+                "server_certificate_file(): failed to open '%s': %s",
                 path, strerror(errno));
         }
         /* Couldn't open the file, special case. */