X-Git-Url: https://ruderich.org/simon/gitweb/?a=blobdiff_plain;f=tests%2Ftests-normal.sh;h=60c56cadfedb80cf8f7ff03d5e7d232020b9fc4f;hb=2768e020f19f47e0d31ed883698a5aba1ad9d3a8;hp=41b6e36817d478b34c8cafec50325ba912917e54;hpb=c955255347f4ca514f26ad96a12524b38d235dee;p=tlsproxy%2Ftlsproxy.git

diff --git a/tests/tests-normal.sh b/tests/tests-normal.sh
index 41b6e36..60c56ca 100755
--- a/tests/tests-normal.sh
+++ b/tests/tests-normal.sh
@@ -2,7 +2,7 @@
 
 # Normal tlsproxy tests.
 #
-# Copyright (C) 2011  Simon Ruderich
+# Copyright (C) 2011-2013  Simon Ruderich
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -21,16 +21,17 @@
 # Handle empty $srcdir.
 [ "x$srcdir" = x ] && srcdir=.
 
-. $srcdir/common.sh
+. "$srcdir/common.sh"
 
 
 # Create necessary files.
-$srcdir/../src/tlsproxy-setup >/dev/null 2>/dev/null
+cleanup
+"$srcdir/../src/tlsproxy-setup" >/dev/null 2>/dev/null
 
 # Normal tests.
 ../src/tlsproxy -d2 4711 >/dev/null &
-server --x509certfile $srcdir/server.pem \
-       --x509keyfile $srcdir/server-key.pem
+server --x509certfile "$srcdir/server.pem" \
+       --x509keyfile "$srcdir/server-key.pem"
 sleep 1
 
 
@@ -45,20 +46,25 @@ test_proxy_successful
 test_invalid_certificate
 
 # Create the proxy certificate.
-$srcdir/../src/tlsproxy-add localhost $srcdir/server.pem \
+"$srcdir/../src/tlsproxy-add" localhost "$srcdir/server.pem" \
     >/dev/null 2>/dev/null
-rm -f certificate-localhost-server.pem
 
 echo missing server certificate
+mv certificate-localhost-server.pem .pem
 client localhost 4712 invalid || abort
+mv .pem certificate-localhost-server.pem
 test_proxy_successful
 test_invalid_certificate
 
-# Create the proxy and server certificate.
-$srcdir/../src/tlsproxy-add localhost $srcdir/server.pem \
-    >/dev/null 2>/dev/null
+echo missing proxy certificate
+mv certificate-localhost-proxy.pem .pem
+client localhost 4712 invalid || abort
+mv .pem certificate-localhost-proxy.pem
+test_proxy_successful
+test_invalid_certificate
 
 echo normal connection
+# 'localhost' is the CN of tlsproxy's certificate.
 client localhost 4712 localhost || abort
 test_proxy_successful
 test_no_invalid_certificate
@@ -67,9 +73,10 @@ test_no_invalid_certificate
 # Stop server and try a "MITM" with a bad certificate.
 echo
 pkill -n gnutls-serv
-server --x509certfile $srcdir/server-bad.pem \
-       --x509keyfile $srcdir/server-key.pem
+server --x509certfile "$srcdir/server-bad.pem" \
+       --x509keyfile "$srcdir/server-key.pem"
 sleep 1
+rm -f certificate-localhost-proxy.pem certificate-localhost-server.pem
 
 
 echo mitm invalid hostname
@@ -83,18 +90,22 @@ test_proxy_successful
 test_invalid_certificate
 
 # Create the proxy certificate.
-$srcdir/../src/tlsproxy-add localhost $srcdir/server.pem \
+"$srcdir/../src/tlsproxy-add" localhost "$srcdir/server.pem" \
     >/dev/null 2>/dev/null
-rm -f certificate-localhost-server.pem
 
 echo mitm missing server certificate
+mv certificate-localhost-server.pem .pem
 client localhost 4712 invalid || abort
+mv .pem certificate-localhost-server.pem
 test_proxy_successful
 test_invalid_certificate
 
-# Create the proxy and server certificate.
-$srcdir/../src/tlsproxy-add localhost $srcdir/server.pem \
-    >/dev/null 2>/dev/null
+echo mitm missing proxy certificate
+mv certificate-localhost-proxy.pem .pem
+client localhost 4712 invalid || abort
+mv .pem certificate-localhost-proxy.pem
+test_proxy_successful
+test_invalid_certificate
 
 echo mitm normal connection
 client localhost 4712 invalid || abort
@@ -105,8 +116,7 @@ test_invalid_certificate
 pkill -n gnutls-serv
 pkill -n tlsproxy
 
-rm -f tmp \
-    certificate-localhost-proxy.pem certificate-localhost-server.pem \
-    proxy-ca-key.pem proxy-ca.pem proxy-invalid.pem proxy-key.pem
+cleanup
+rm -f tmp
 
 exit 0