It's confusing to show nothing at all when no changes occur on a host.
To inform the user that the sync was successful but nothing changed
display a short message.
true,
[]string{"no-settings.example.org"},
`<LOG>[info] [no-settings.example.org] remote helper upload in progress
true,
[]string{"no-settings.example.org"},
`<LOG>[info] [no-settings.example.org] remote helper upload in progress
+<LOG>[info] [no-settings.example.org] no changes
"no settings (no helper upload)",
false,
[]string{"no-settings.example.org"},
"no settings (no helper upload)",
false,
[]string{"no-settings.example.org"},
+ `<LOG>[info] [no-settings.example.org] no changes
+`,
+ nil,
+ },
+ {
+ "no settings (error)",
+ true,
+ []string{"-log", "error", "no-settings.example.org"},
`<LOG>[info] [no-settings.example.org] remote helper upload in progress
<LOG>[verbose] [no-settings.example.org] host groups: all <DET> <DET> no-settings.example.org
<LOG>[verbose] [no-settings.example.org] host group priorities (desc. order): no-settings.example.org
`<LOG>[info] [no-settings.example.org] remote helper upload in progress
<LOG>[verbose] [no-settings.example.org] host groups: all <DET> <DET> no-settings.example.org
<LOG>[verbose] [no-settings.example.org] host group priorities (desc. order): no-settings.example.org
+<LOG>[info] [no-settings.example.org] no changes
`<LOG>[info] [no-settings.example.org] remote helper upload in progress
<LOG>[verbose] [no-settings.example.org] host groups: all <DET> <DET> no-settings.example.org
<LOG>[verbose] [no-settings.example.org] host group priorities (desc. order): no-settings.example.org
`<LOG>[info] [no-settings.example.org] remote helper upload in progress
<LOG>[verbose] [no-settings.example.org] host groups: all <DET> <DET> no-settings.example.org
<LOG>[verbose] [no-settings.example.org] host group priorities (desc. order): no-settings.example.org
+<LOG>[info] [no-settings.example.org] no changes
s.formatCommandChanges(resp.CommandChanges))
}
if len(changes) == 0 {
s.formatCommandChanges(resp.CommandChanges))
}
if len(changes) == 0 {
+ // Notify user that the host was synced successfully
+ return "no changes"
}
x := strings.Join(changes, "\n")
}
x := strings.Join(changes, "\n")
false,
false,
safcm.MsgSyncResp{},
false,
false,
safcm.MsgSyncResp{},