1 // Simple RPC-like protocol: establish new connection and upload helper
3 // Copyright (C) 2021 Simon Ruderich
5 // This program is free software: you can redistribute it and/or modify
6 // it under the terms of the GNU General Public License as published by
7 // the Free Software Foundation, either version 3 of the License, or
8 // (at your option) any later version.
10 // This program is distributed in the hope that it will be useful,
11 // but WITHOUT ANY WARRANTY; without even the implied warranty of
12 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 // GNU General Public License for more details.
15 // You should have received a copy of the GNU General Public License
16 // along with this program. If not, see <http://www.gnu.org/licenses/>.
31 "ruderich.org/simon/safcm"
32 "ruderich.org/simon/safcm/remote"
35 func (c *Conn) DialSSH(remote string) error {
37 return fmt.Errorf("cannot reuse Conn")
40 c.debugf("DialSSH: connecting to %q", remote)
44 // Help debugging by showing executed shell commands
47 c.cmd = exec.Command("ssh", remote, "/bin/sh", opts)
50 stdin, err := c.cmd.StdinPipe()
54 stdout, err := c.cmd.StdoutPipe()
58 err = c.handleStderrAsEvents(c.cmd)
68 err = c.dialSSH(stdin, stdout)
73 c.conn = safcm.NewGobConn(stdout, stdin)
78 func (c *Conn) dialSSH(stdin io.Writer, stdout_ io.Reader) error {
79 stdout := bufio.NewReader(stdout_)
81 goos, err := connGetGoos(stdin, stdout)
85 goarch, err := connGetGoarch(stdin, stdout)
89 uid, err := connGetUID(stdin, stdout)
94 path := fmt.Sprintf("/tmp/safcm-remote-%d", uid)
96 c.debugf("DialSSH: probing remote at %q", path)
97 // Use a function so the shell cannot execute the input line-wise.
98 // This is important because we're also using stdin to send data to
99 // the script. If the shell executes the input line-wise then our
100 // script is interpreted as input for `read`.
102 // The target directory must no permit other users to delete our files
103 // or symlink attacks and arbitrary code execution is possible. For
104 // /tmp this is guaranteed by the sticky bit. Make sure it has the
105 // proper permissions.
107 // We cannot use `test -f && test -O` because this is open to TOCTOU
108 // attacks. `stat` gives use the full file state. If the file is owned
109 // by us and not a symlink then it's safe to use (assuming sticky or
110 // directory not writable by others).
112 // `test -e` is only used to prevent error messages if the file
113 // doesn't exist. It does not guard against any races.
114 _, err = fmt.Fprintf(stdin, `
118 dir="$(dirname "$x")"
119 if ! test "$(stat -c '%%A %%u %%g' "$dir")" = 'drwxrwxrwt 0 0'; then
120 echo "unsafe permissions on $dir, aborting" >&2
124 if test -e "$x" && test "$(stat -c '%%A %%u' "$x")" = "-rwx------ $(id -u)"; then
128 # Empty checksum to request upload
132 # Wait for signal to continue
135 if test -n "$upload"; then
136 tmp="$(mktemp "$x.XXXXXX")"
137 # Report filename for upload
140 # Wait for upload to complete
143 # Safely create new file (ln does not follow symlinks)
147 # Make file executable
158 remoteSum, err := stdout.ReadString('\n')
163 // Get embedded helper binary
164 helper, err := remote.Helpers.ReadFile(
165 fmt.Sprintf("helpers/%s-%s", goos, goarch))
167 return fmt.Errorf("remote not built for GOOS/GOARCH %s/%s",
172 if remoteSum == "\n" {
174 c.debugf("DialSSH: remote not present or invalid permissions")
177 x := strings.Fields(remoteSum)
179 return fmt.Errorf("got unexpected checksum line %q",
182 sha := sha512.Sum512(helper)
183 hex := hex.EncodeToString(sha[:])
185 c.debugf("DialSSH: remote checksum matches")
188 c.debugf("DialSSH: remote checksum does not match")
193 // Notify user that an upload is going to take place.
194 c.events <- ConnEvent{
195 Type: ConnEventUpload,
198 // Tell script we want to upload a new file.
199 _, err = fmt.Fprintln(stdin, "upload")
203 // Get path to temporary file for upload.
205 // Write to the temporary file instead of the final path so
206 // that a concurrent run of this function won't use a
207 // partially written file. The rm in the script could still
208 // cause a missing file but at least no file with unknown
209 // content is executed.
210 path, err := stdout.ReadString('\n')
214 path = strings.TrimSuffix(path, "\n")
216 c.debugf("DialSSH: uploading new remote to %q at %q",
219 cmd := exec.Command("ssh", c.remote,
220 fmt.Sprintf("cat > %q", path))
221 cmd.Stdin = bytes.NewReader(helper)
222 err = c.handleStderrAsEvents(cmd)
232 // Tell script to continue and execute the remote helper
233 _, err = fmt.Fprintln(stdin, "")
241 func connGetGoos(stdin io.Writer, stdout *bufio.Reader) (string, error) {
242 _, err := fmt.Fprintln(stdin, "uname -o")
246 x, err := stdout.ReadString('\n')
250 x = strings.TrimSpace(x)
252 // NOTE: Adapt helper uploading in dialSSH() when adding new systems
258 return "", fmt.Errorf("unsupported OS %q (`uname -o`)", x)
263 func connGetGoarch(stdin io.Writer, stdout *bufio.Reader) (string, error) {
264 _, err := fmt.Fprintln(stdin, "uname -m")
268 x, err := stdout.ReadString('\n')
272 x = strings.TrimSpace(x)
274 // NOTE: Adapt cmd/safcm-remote/build.sh when adding new architectures
280 return "", fmt.Errorf("unsupported arch %q (`uname -m`)", x)
285 func connGetUID(stdin io.Writer, stdout *bufio.Reader) (int, error) {
286 _, err := fmt.Fprintln(stdin, "id -u")
290 x, err := stdout.ReadString('\n')
294 x = strings.TrimSpace(x)
296 uid, err := strconv.Atoi(x)
298 return -1, fmt.Errorf("invalid UID %q (`id -u`)", x)