Use command grouping to reduce number of redirects

Suggested by shellcheck and makes the code more readable.

diff --git a/lib.sh b/lib.sh
index bb60c521b959d79ecba52b33dd7e9c4bcd74de36..1ce0c33c4e96468aab048bf1b40d3997ab486819 100644 (file)
--- a/lib.sh
+++ b/lib.sh
@@ -196,13 +196,15 @@ generate() {
         printf '%s: generating from "%s" (%s)\n' \
             "$file" "$file$extension" "$1"
 
-        echo '###################################'  >"$file"
-        echo '# WARNING! DO NOT EDIT THIS FILE! #' >>"$file"
-        echo '###################################' >>"$file"
-        echo >>"$file"
-        printf '# It was generated from "%s" on %s.\n' \
-            "$file$extension" "`date`" >>"$file"
-        echo >>"$file"
+        {
+            echo '###################################'
+            echo '# WARNING! DO NOT EDIT THIS FILE! #'
+            echo '###################################'
+            echo
+            printf '# It was generated from "%s" on %s.\n' \
+                "$file$extension" "`date`"
+            echo
+        } > "$file"
 
         file_tmp="$file"
     fi

diff --git a/shell/crontab.d/setup.sh b/shell/crontab.d/setup.sh
index 603e3019238611eff636ce9542a133bcdcf0e800..0abf260d9a938ee8dc9d5cca1fb14ca6c5c88fbc 100755 (executable)
--- a/shell/crontab.d/setup.sh
+++ b/shell/crontab.d/setup.sh
@@ -46,12 +46,14 @@ fi
 # `set -e` aborts when `mktemp` fails.
 CRONTAB=`mktemp --tmpdir="$DIRECTORY" update-crontab.XXXXXXXXXXXX`
 
-echo '###################################'  >"$CRONTAB"
-echo "$HEADER_WARNING"                     >>"$CRONTAB"
-echo '###################################' >>"$CRONTAB"
-echo >>"$CRONTAB"
-printf '# It was generated from "%s/*" on %s.' \
-    "$DIRECTORY" "`LANG=C date '+%a, %d %b %Y %H:%M:%S %z'`" >>"$CRONTAB"
+{
+    echo '###################################'
+    echo "$HEADER_WARNING"
+    echo '###################################'
+    echo
+    printf '# It was generated from "%s/*" on %s.' \
+        "$DIRECTORY" "`LANG=C date '+%a, %d %b %Y %H:%M:%S %z'`"
+} > "$CRONTAB"
 
 # Enforce C sort order.
 LC_ALL=C