trackfds.h: Remove unnecessary strdup().

[coloredstderr/coloredstderr.git] / src / trackfds.h

diff --git a/src/trackfds.h b/src/trackfds.h
index b26059da533d8119e96551f80acac5bdf3101df0..5896cbb4ee3eb223db010131253bb609d45de774 100644 (file)
--- a/src/trackfds.h
+++ b/src/trackfds.h
@@ -28,12 +28,27 @@ static size_t tracked_fds_count;
 static size_t tracked_fds_space;
 
 
+#ifdef DEBUG
+static void tracked_fds_debug(void) {
+    debug("    tracked_fds: %d/%d\t\t[%d]\n", tracked_fds_count,
+                                              tracked_fds_space,
+                                              getpid());
+    size_t i;
+    for (i = 0; i < tracked_fds_count; i++) {
+        debug("    tracked_fds[%d]: %d\n", i, tracked_fds[i]);
+    }
+}
+#endif
+
 /* Load tracked file descriptors from the environment. The environment is used
  * to pass the information to child processes.
  *
  * ENV_NAME_FDS has the following format: Each descriptor as string followed
  * by a comma; there's a trailing comma. Example: "2,4,". */
 static void init_from_environment(void) {
+#ifdef DEBUG
+    debug("init_from_environment()\t\t[%d]\n", getpid());
+#endif
     const char *env;
 
     initialized = 1;
@@ -51,10 +66,8 @@ static void init_from_environment(void) {
         return;
     }
     /* Environment is read-only. */
-    char *env_copy = strdup(env);
-    if (!env_copy) {
-        return;
-    }
+    char env_copy[strlen(env) + 1];
+    strcpy(env_copy, env);
 
     char *x;
 
@@ -68,7 +81,6 @@ static void init_from_environment(void) {
 
     tracked_fds = malloc(tracked_fds_space * sizeof(*tracked_fds));
     if (!tracked_fds) {
-        free(env_copy);
         return;
     }
 
@@ -99,21 +111,17 @@ static void init_from_environment(void) {
 
     tracked_fds_count = count;
 
-    free(env_copy);
+#ifdef DEBUG
+    tracked_fds_debug();
+#endif
 }
 
-static void update_environment(void) {
-    /* An integer (32-bit) has at most 10 digits, + 1 for the comma after each
-     * number. Bigger file descriptors (which shouldn't occur in reality) are
-     * skipped. */
-    char env[tracked_fds_count * (10 + 1) * sizeof(char)];
-    char *x = env;
-
+static void update_environment_buffer(char *x) {
     size_t i;
     for (i = 0; i < tracked_fds_count; i++) {
         int length = snprintf(x, 10 + 1, "%d", tracked_fds[i]);
         if (length >= 10 + 1) {
-            /* Integer too bit to fit the buffer, skip it. */
+            /* Integer too big to fit the buffer, skip it. */
             continue;
         }
 
@@ -123,37 +131,60 @@ static void update_environment(void) {
         /* Make sure the string is always zero terminated. */
         *x = 0;
     }
+}
+inline static size_t update_environment_buffer_size(void) {
+    /* An integer (32-bit) has at most 10 digits, + 1 for the comma after each
+     * number. Bigger file descriptors (which shouldn't occur in reality) are
+     * skipped. */
+    return tracked_fds_count * (10 + 1) + 1 /* to fit '\0' */;
+}
+static void update_environment(void) {
+#ifdef DEBUG
+    debug("update_environment()\t\t[%d]\n", getpid());
+#endif
+
+    /* If we haven't parsed the environment we also haven't modified it - so
+     * nothing to do. */
+    if (!initialized) {
+        return;
+    }
+
+    char env[update_environment_buffer_size()];
+    env[0] = 0;
+
+    update_environment_buffer(env);
+
+#if 0
+    debug("    setenv('%s', '%s', 1)\n", ENV_NAME_FDS, env);
+#endif
 
     setenv(ENV_NAME_FDS, env, 1 /* overwrite */);
 }
 
 
-#ifdef DEBUG
-static void tracked_fds_debug(void) {
-    debug("tracked_fds: %d/%d\t[%d]\n", tracked_fds_count, tracked_fds_space,
-                                        getpid());
-    size_t i;
-    for (i = 0; i < tracked_fds_count; i++) {
-        debug("tracked_fds[%d]: %d\n", i, tracked_fds[i]);
-    }
-}
-#endif
 
 static void tracked_fds_add(int fd) {
     if (tracked_fds_count >= tracked_fds_space) {
         size_t new_space = tracked_fds_space + TRACKFDS_REALLOC_STEP;
-        if (!realloc(tracked_fds, sizeof(*tracked_fds) * new_space)) {
+        int *tmp = realloc(tracked_fds, sizeof(*tracked_fds) * new_space);
+        if (!tmp) {
             /* We can do nothing, just ignore the error. We made sure not to
              * destroy our state, so the new descriptor is ignored without any
              * other consequences. */
+#ifdef DEBUG
+            debug("realloc(tracked_fds, %zu) failed! [%d]\n",
+                  sizeof(*tracked_fds) * new_space, getpid());
+#endif
             return;
         }
+        tracked_fds = tmp;
         tracked_fds_space = new_space;
     }
 
     tracked_fds[tracked_fds_count++] = fd;
 
 #ifdef DEBUG
+    debug("tracked_fds_add(): %-3d\t\t[%d]\n", fd, getpid());
     tracked_fds_debug();
 #endif
 }
@@ -169,6 +200,7 @@ static int tracked_fds_remove(int fd) {
         tracked_fds_count--;
 
 #ifdef DEBUG
+        debug("tracked_fds_remove(): %-3d\t[%d]\n", fd, getpid());
         tracked_fds_debug();
 #endif