Don't use echo for data from the user.

[config/dotfiles.git] / setup.sh

diff --git a/setup.sh b/setup.sh
index cf7eb54fe5cf5afe3ab45b405754f0202d000909..2190af18ab82f68e1530cdf0870c4490ed80d844 100755 (executable)
--- a/setup.sh
+++ b/setup.sh
@@ -25,13 +25,11 @@ for path in */setup.sh; do
     # Skip non executable setup.sh files as an easy way to deactivate one.
     test ! -x "$path" && continue
 
-    project=`echo "$path" | sed 's|/setup.sh$||'`
+    project=`printf '%s' "$path" | sed 's|/setup.sh$||'`
 
-    echo "running setup.sh in '$project'"
-    if ( cd "$project"; ./setup.sh >/dev/null ); then
-        :
-    else
-        echo "$project/setup.sh failed" >&2
+    printf "running setup.sh in '%s'\n" "$project"
+    ( cd "$project" && ./setup.sh >/dev/null ) || {
+        printf '%s/setup.sh failed\n' "$project" >&2
         exit 1
-    fi
+    }
 done