Don't use echo for data from the user.

[config/dotfiles.git] / setup.sh

diff --git a/setup.sh b/setup.sh
index 81df8b190136d59898ce37cf203d36c54e93e86d..2190af18ab82f68e1530cdf0870c4490ed80d844 100755 (executable)
--- a/setup.sh
+++ b/setup.sh
@@ -21,14 +21,15 @@
 
 set -e
 
-for path in `find . -name setup.sh -type f`; do
-    # Skip this directory to prevent an infinite loop.
-    [ "$path" = "./setup.sh" ] && continue
+for path in */setup.sh; do
     # Skip non executable setup.sh files as an easy way to deactivate one.
-    [ ! -x "$path" ] && continue
+    test ! -x "$path" && continue
 
-    project=`echo "$path" | sed 's|/setup.sh$||'`
+    project=`printf '%s' "$path" | sed 's|/setup.sh$||'`
 
-    echo "running setup.sh in '$project'"
-    ( cd "$project"; ./setup.sh > /dev/null )
+    printf "running setup.sh in '%s'\n" "$project"
+    ( cd "$project" && ./setup.sh >/dev/null ) || {
+        printf '%s/setup.sh failed\n' "$project" >&2
+        exit 1
+    }
 done