README: misc updates

[nsscash/nsscash.git] / passwd.go

diff --git a/passwd.go b/passwd.go
index 54da63b3f30252f65e5c1717318b683686a037c1..7364639d8e2c3581fe71030b85fac22cfee58456 100644 (file)
--- a/passwd.go
+++ b/passwd.go
@@ -23,6 +23,7 @@ import (
        "encoding/binary"
        "fmt"
        "io"
+       "math"
        "sort"
        "strconv"
        "strings"
@@ -53,6 +54,11 @@ func ParsePasswds(r io.Reader) ([]Passwd, error) {
                t, err := s.ReadString('\n')
                if err != nil {
                        if err == io.EOF {
+                               if t != "" {
+                                       return nil, fmt.Errorf(
+                                               "no newline in last line: %q",
+                                               t)
+                               }
                                break
                        }
                        return nil, err
@@ -103,6 +109,11 @@ func SerializePasswd(p Passwd) ([]byte, error) {
        offShell := uint16(data.Len())
        data.Write([]byte(p.Shell))
        data.WriteByte(0)
+       // Ensure the offsets can fit the length of this entry
+       if data.Len() > math.MaxUint16 {
+               return nil, fmt.Errorf("passwd too large to serialize: %v, %v",
+                       data.Len(), p)
+       }
        size := uint16(data.Len())
 
        var res bytes.Buffer // serialized result