]> ruderich.org/simon Gitweb - nsscash/nsscash.git/commitdiff
nss: gr/pw: use key->name for NULL check
authorSimon Ruderich <simon@ruderich.org>
Mon, 10 Jun 2019 20:57:40 +0000 (22:57 +0200)
committerSimon Ruderich <simon@ruderich.org>
Mon, 10 Jun 2019 20:57:40 +0000 (22:57 +0200)
This is consistent with search.c's bsearch_callback() which also checks
key->name first.

nss/gr.c
nss/pw.c

index 8b336f9615bb4b0c200417240fa82f76ebb87166..cc7f9b0d3b428a48ffafb11b48f626fb3ba91d6a 100644 (file)
--- a/nss/gr.c
+++ b/nss/gr.c
@@ -154,9 +154,9 @@ static enum nss_status internal_getgr(struct search_key *key, struct group *resu
     const struct header *h = f.header;
 
     key->data = h->data + h->off_data;
-    uint64_t off_index = (key->id != NULL)
-                       ? h->off_id_index
-                       : h->off_name_index;
+    uint64_t off_index = (key->name != NULL)
+                       ? h->off_name_index
+                       : h->off_id_index;
     uint64_t *off = search(key, h->data + off_index, h->count);
     if (off == NULL) {
         unmap_file(&f);
index 4313ee376cfa2e008756a776c4ff0aa4802bbf41..c7e056666216c1cf7e3143dd5626583d1b22298d 100644 (file)
--- a/nss/pw.c
+++ b/nss/pw.c
@@ -140,9 +140,9 @@ static enum nss_status internal_getpw(struct search_key *key, struct passwd *res
     const struct header *h = f.header;
 
     key->data = h->data + h->off_data;
-    uint64_t off_index = (key->id != NULL)
-                       ? h->off_id_index
-                       : h->off_name_index;
+    uint64_t off_index = (key->name != NULL)
+                       ? h->off_name_index
+                       : h->off_id_index;
     uint64_t *off = search(key, h->data + off_index, h->count);
     if (off == NULL) {
         unmap_file(&f);