unix.Unlinkat(parentFd, tmpBase, 0)
return err
}
+ // To guarantee durability fsync must be called on a parent directory
+ // after adding, renaming or removing files therein.
+ //
+ // Calling sync on the files itself is not enough according to POSIX;
+ // man 2 fsync: "Calling fsync() does not necessarily ensure that the
+ // entry in the directory containing the file has also reached disk.
+ // For that an explicit fsync() on a file descriptor for the directory
+ // is also needed."
err = unix.Fsync(parentFd)
if err != nil {
return err
}
dir = ".."
parts = []string{filepath.Base(wd)}
- } else if parts[0] != "." {
+ } else {
// Relative path: start at the current directory
dir = "."
+ if parts[0] == "." {
+ parts = parts[1:]
+ }
}
dirFd, err := unix.Openat(unix.AT_FDCWD, dir, openReadonlyFlags, 0)
return os.NewFile(uintptr(fd), ""), tmpBase, nil
}
-
-// SyncPath syncs path, which should be a directory. To guarantee durability
-// it must be called on a parent directory after adding, renaming or removing
-// files therein.
-//
-// Calling sync on the files itself is not enough according to POSIX; man 2
-// fsync: "Calling fsync() does not necessarily ensure that the entry in the
-// directory containing the file has also reached disk. For that an explicit
-// fsync() on a file descriptor for the directory is also needed."
-func SyncPath(path string) error {
- x, err := os.Open(path)
- if err != nil {
- return err
- }
- err = x.Sync()
- closeErr := x.Close()
- if err != nil {
- return err
- }
- return closeErr
-}