src/: Prefix all global variables with global_.

[tlsproxy/tlsproxy.git] / src / tlsproxy.c

diff --git a/src/tlsproxy.c b/src/tlsproxy.c
index ab9c6dff6c848b53597c2195662f752cf7ad940c..39183a7753d78742bca861408ae223a3bfe6f639 100644 (file)
--- a/src/tlsproxy.c
+++ b/src/tlsproxy.c
@@ -17,11 +17,10 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include <config.h>
+#include "tlsproxy.h"
+#include "sem.h"
+#include "connection.h"
 
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
 /* socket(), bind(), accept(), listen() */
 #include <sys/types.h>
 #include <sys/socket.h>
@@ -36,10 +35,6 @@
 /* pthread_*() */
 #include <pthread.h>
 
-#include "tlsproxy.h"
-#include "sem.h"
-#include "connection.h"
-
 /* Size of ringbuffer. */
 #define RINGBUFFER_SIZE 10
 
@@ -81,7 +76,7 @@ int main(int argc, char **argv) {
     port = atoi(argv[argc - 1]);
     if (0 >= port || 0xffff < port) {
         print_usage(argv[0]);
-        fprintf(stderr, "\ninvalid port");
+        fprintf(stderr, "\ninvalid port\n");
         return EXIT_FAILURE;
     }
 
@@ -160,8 +155,8 @@ int main(int argc, char **argv) {
 #ifdef DEBUG
     printf("Listening for connections on port %d.\n", port);
 
-    if (NULL != use_proxy_host && NULL != use_proxy_port) {
-        printf("Using proxy: %s:%s.\n", use_proxy_host, use_proxy_port);
+    if (NULL != global_proxy_host && NULL != global_proxy_port) {
+        printf("Using proxy: %s:%s.\n", global_proxy_host, global_proxy_port);
     }
 #endif
 
@@ -203,8 +198,8 @@ int main(int argc, char **argv) {
 
     free(threads);
 
-    free(use_proxy_host);
-    free(use_proxy_port);
+    free(global_proxy_host);
+    free(global_proxy_port);
 
     return EXIT_FAILURE;
 }
@@ -232,30 +227,32 @@ static void parse_arguments(int argc, char **argv) {
                         || 0 == strlen(position + 1)
                         || 0 >= atoi(position + 1)
                         || 0xffff < atoi(position + 1)) {
-                    fprintf(stderr, "-p host:port\n");
+                    print_usage(argv[0]);
+                    fprintf(stderr, "\ninvalid -p, format host:port\n");
                     exit(EXIT_FAILURE);
                 }
 
-                use_proxy_host = malloc((size_t)(position - optarg) + 1);
-                if (NULL == use_proxy_host) {
+                global_proxy_host = malloc((size_t)(position - optarg) + 1);
+                if (NULL == global_proxy_host) {
                     perror("malloc()");
                     exit(EXIT_FAILURE);
                 }
-                memcpy(use_proxy_host, optarg, (size_t)(position - optarg));
-                use_proxy_host[position - optarg] = '\0';
+                memcpy(global_proxy_host, optarg, (size_t)(position - optarg));
+                global_proxy_host[position - optarg] = '\0';
 
-                use_proxy_port = malloc(strlen(position + 1) + 1);
-                if (NULL == use_proxy_port) {
+                global_proxy_port = malloc(strlen(position + 1) + 1);
+                if (NULL == global_proxy_port) {
                     perror("malloc()");
                     exit(EXIT_FAILURE);
                 }
-                strcpy(use_proxy_port, position + 1);
+                strcpy(global_proxy_port, position + 1);
 
                 break;
             }
             case 't': {
                 if (0 >= atoi(optarg)) {
-                    fprintf(stderr, "-t positive number required\n");
+                    print_usage(argv[0]);
+                    fprintf(stderr, "\n-t positive number required\n");
                     exit(EXIT_FAILURE);
                 }
                 thread_count = (size_t)atoi(optarg);
@@ -270,11 +267,12 @@ static void parse_arguments(int argc, char **argv) {
 
     if (optind >= argc) {
         print_usage(argv[0]);
+        fprintf(stderr, "\nport missing\n");
         exit(EXIT_FAILURE);
     }
 }
 static void print_usage(const char *argv) {
-    fprintf(stderr, "Usage: %s [-p host:port] port\n", argv);
+    fprintf(stderr, "Usage: %s [-p host:port] [-t count] port\n", argv);
     fprintf(stderr, "\n");
     fprintf(stderr, "-p proxy hostname and port\n");
     fprintf(stderr, "-t number of threads [default: 10]\n");
@@ -293,7 +291,7 @@ static void worker_thread(void) {
         V(ringbuffer_free);
 
         /* Negative value indicates we should shut down our thread. */
-        if (client_socket < 0) {
+        if (0 > client_socket) {
             break;
         }