src/connection.c: Reduce calls to gnutls_record_get_max_size().

[tlsproxy/tlsproxy.git] / src / verify.c

diff --git a/src/verify.c b/src/verify.c
index 5248dd6cd243dff33609066f3da00c0c3a6bf5ce..63ca6da2d982a121d36cb8b6779e795ba0c72f30 100644 (file)
--- a/src/verify.c
+++ b/src/verify.c
@@ -157,6 +157,8 @@ int verify_tls_connection(gnutls_session_t session, const char *hostname) {
 
 int server_certificate_path(FILE **file, const char *hostname,
                             char *path, size_t size) {
+    int result;
+
     /* Hostname too long. */
     if (size - strlen(STORED_SERVER_CERT_FORMAT) <= strlen(hostname)) {
         LOG(LOG_WARNING,
@@ -171,7 +173,16 @@ int server_certificate_path(FILE **file, const char *hostname,
             hostname);
         return -1;
     }
-    snprintf(path, size, STORED_SERVER_CERT_FORMAT, hostname);
+    result = snprintf(path, size, STORED_SERVER_CERT_FORMAT, hostname);
+    if (result < 0) {
+        LOG_PERROR(LOG_ERROR,
+                   "server_certificate_path(): snprintf failed");
+        return -1;
+    } else if ((size_t)result >= size) {
+        LOG(LOG_ERROR,
+            "server_certificate_path(): snprintf buffer too short");
+        return -1;
+    }
 
     /* Open the stored certificate file. */
     *file = fopen(path, "rb");