tests: Correctly handle cleanup of (temporary) files.

diff --git a/tests/common.sh b/tests/common.sh
index 05641db98ad8482141a03acc9f87ae64eef64f33..e006698ab397d0e6fe480ef2293b07f65d2d644a 100644 (file)
--- a/tests/common.sh
+++ b/tests/common.sh
@@ -16,6 +16,11 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 
+cleanup() {
+    rm -f \
+        certificate-localhost-proxy.pem certificate-localhost-server.pem \
+        proxy-ca-key.pem proxy-ca.pem proxy-invalid.pem proxy-key.pem
+}
 abort() {
     echo abort
     pkill -n gnutls-serv

diff --git a/tests/tests-normal.sh b/tests/tests-normal.sh
index 41b6e36817d478b34c8cafec50325ba912917e54..a8169dcd2f8dcfefca9ba175d00ba0b6070f0f91 100755 (executable)
--- a/tests/tests-normal.sh
+++ b/tests/tests-normal.sh
@@ -25,6 +25,7 @@
 
 
 # Create necessary files.
+cleanup
 $srcdir/../src/tlsproxy-setup >/dev/null 2>/dev/null
 
 # Normal tests.
@@ -70,6 +71,7 @@ pkill -n gnutls-serv
 server --x509certfile $srcdir/server-bad.pem \
        --x509keyfile $srcdir/server-key.pem
 sleep 1
+rm -f certificate-localhost-proxy.pem certificate-localhost-server.pem
 
 
 echo mitm invalid hostname
@@ -105,8 +107,7 @@ test_invalid_certificate
 pkill -n gnutls-serv
 pkill -n tlsproxy
 
-rm -f tmp \
-    certificate-localhost-proxy.pem certificate-localhost-server.pem \
-    proxy-ca-key.pem proxy-ca.pem proxy-invalid.pem proxy-key.pem
+cleanup
+rm -f tmp
 
 exit 0